Skip to content

chore: call sandbox.close() instead of internal functions #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marvinhagemeister merged 1 commit into from
Jan 21, 2026
Merged

chore: call sandbox.close() instead of internal functions #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/deno_sandbox/sandbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,11 +184,14 @@ async def create(
if sandbox_id is None:
raise Exception("Sandbox ID not found in response headers")

sandbox = None
try:
rpc = AsyncRpcClient(transport)
yield AsyncSandbox(self._client, rpc, sandbox_id)
sandbox = AsyncSandbox(self._client, rpc, sandbox_id)
yield sandbox
finally:
await transport.close()
if sandbox is not None:
await sandbox.close()

@asynccontextmanager
async def connect(
Expand All @@ -210,11 +213,14 @@ async def connect(
},
)

sandbox = None
try:
rpc = AsyncRpcClient(transport)
yield AsyncSandbox(self._client, rpc, sandbox_id)
sandbox = AsyncSandbox(self._client, rpc, sandbox_id)
yield sandbox
finally:
await transport.close()
if sandbox is not None:
await sandbox.close()

async def list(
self, options: Optional[SandboxListOptions] = None
Expand Down