refactor: switch to single config file and deno.json again#103
Open
csvn wants to merge 2 commits intodenoland:mainfrom
Open
refactor: switch to single config file and deno.json again#103csvn wants to merge 2 commits intodenoland:mainfrom
csvn wants to merge 2 commits intodenoland:mainfrom
Conversation
csvn
commented
May 16, 2025
Comment on lines
+2
to
+6
| "name": "@deno/setup-deno", | ||
| "description": "Set up Deno easily in GitHub Actions", | ||
| "version": "2.0.3", | ||
| "license": "MIT", | ||
| "exports": "./src/cache.ts", |
Contributor
Author
There was a problem hiding this comment.
The exports property was needed since I added the name property with @deno/setup-deno to mimic package.json. Though both can be removed preferable.
csvn
force-pushed
the
refactor/avoid-double-config-files
branch
from
19765da to
69cb87d
Compare
Contributor
Author
|
@crowlKats WDYT about this PR? I think it would simplify to again remove the unnecessary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given what's mentioned by @crowlKats in #101 (comment), I thought perhaps it's better to combine
deno.json+package.jsoninto onlydeno.jsononce more. Given that all metadata for the action comes fromaction.yml.The
versionfield indeno.jsoncan instead be used if it's preferable to have PR's (e.g. #102) when new versions are released. The only field that has no equivalent indeno.jsonis theauthorfield, though I don't think there's any purpose to it when this field exists inaction.yml.