Skip to content

feat: add warning for setup-deno v1 #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crowlKats wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add warning for setup-deno v1 #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f06e8a
feat: add warning for setup-deno v1
crowlKats Oct 2, 2024
70768ed
fmt
crowlKats Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions main.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ function exit(message) {
}

async function main() {
core.warning(
"Running on setup-deno@1, which is deprecated.\nPlease update to setup-deno@2, which defaults to Deno 2.0",

@lucacasonato lucacasonato Oct 2, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Running on setup-deno@1, which is deprecated.\nPlease update to setup-deno@2, which defaults to Deno 2.0",
"Running on setup-deno@v1, which is deprecated.\nPlease update to setup-deno@v2, which defaults to Deno 2.0",

Add a link to more info. That link should mention that you can use 1.x with setup-deno@v2`.

);

try {
const denoVersionFile = core.getInput("deno-version-file");
const range = parseVersionRange(
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "setup-deno",
"description": "Set up Deno easially in GitHub Actions",
"version": "1.5.1",
"version": "1.5.2",
"author": "Deno Land Inc",
"license": "MIT",
"type": "module",
Expand Down