Skip to content

fix(data-structures): implement deep cloning for BinarySearchNode and… #6316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jiangshengdev
Copy link
Contributor

… update BinarySearchTree.from() to ensure independent copies


Although this change fixes the tree replication issue, it also changes the original behavior of nodes. If a user implements other trees (such as AVL trees) based on this node. Then it may cause other problems. So this merge is only a reference and may not be merged

… update BinarySearchTree.from() to ensure independent copies
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (08fe910) to head (f6f5a4f).
Report is 205 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6316      +/-   ##
==========================================
- Coverage   96.34%   96.34%   -0.01%     
==========================================
  Files         547      547              
  Lines       41671    41665       -6     
  Branches     6314     6309       -5     
==========================================
- Hits        40147    40141       -6     
  Misses       1482     1482              
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jiangshengdev
Copy link
Contributor Author

#6314

@kt3k
Copy link
Member

kt3k commented May 12, 2025

Closing as this is stale. Please reopen when you think it's ready

@kt3k kt3k closed this May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants