Skip to content

fix(csv): add columns options type for array items #6363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from

Conversation

timreichen
Copy link
Contributor

Adds number type only for columns option when items are arrays.

Related: #2660

@timreichen timreichen requested a review from kt3k as a code owner January 24, 2025 09:57
@github-actions github-actions bot added the csv label Jan 24, 2025
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.53%. Comparing base (390845e) to head (5f89e9b).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6363      +/-   ##
==========================================
- Coverage   94.54%   94.53%   -0.01%     
==========================================
  Files         580      580              
  Lines       43730    43731       +1     
  Branches     6471     6470       -1     
==========================================
- Hits        41345    41343       -2     
- Misses       2342     2345       +3     
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timreichen timreichen requested a review from kt3k February 14, 2025 17:49
* @example Give an array of string arrays and specify columns with renaming
* ```ts
* import { stringify } from "@std/csv/unstable-stringify";
* import { stringify } from "@std/csv/stringify";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this example doesn't pass type checking anymore. Why do you change the specifier here to the stable version?

@kt3k
Copy link
Member

kt3k commented Apr 23, 2025

Sorry for the delay in review, but I don't think we can merge this change as this doesn't pass many of existing test cases in stringify_test.ts.

We plan to replace stringify with unstable-stringify in the future with some stabilization process. This makes unstable-stringify incompatible with stable stringify, and that makes future stabilization impossible.

@kt3k
Copy link
Member

kt3k commented May 12, 2025

Closing as it's stale and also the suggested interface is not compatible with the existing stable stringify

@kt3k kt3k closed this May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants