-
Notifications
You must be signed in to change notification settings - Fork 653
fix(csv): add columns
options type for array items
#6363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6363 +/- ##
==========================================
- Coverage 94.54% 94.53% -0.01%
==========================================
Files 580 580
Lines 43730 43731 +1
Branches 6471 6470 -1
==========================================
- Hits 41345 41343 -2
- Misses 2342 2345 +3
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* @example Give an array of string arrays and specify columns with renaming | ||
* ```ts | ||
* import { stringify } from "@std/csv/unstable-stringify"; | ||
* import { stringify } from "@std/csv/stringify"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this example doesn't pass type checking anymore. Why do you change the specifier here to the stable version?
Sorry for the delay in review, but I don't think we can merge this change as this doesn't pass many of existing test cases in We plan to replace |
Closing as it's stale and also the suggested interface is not compatible with the existing stable |
Adds number type only for
columns
option when items are arrays.Related: #2660