Skip to content

BREAKING(cli/unstable): rename ProgressBar end() method to stop() #6406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

timreichen
Copy link
Contributor

This PR renames ProgressBar end() method to stop() to align with Spinner.

@timreichen timreichen requested a review from kt3k as a code owner February 15, 2025 10:37
@github-actions github-actions bot added the cli label Feb 15, 2025
Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.08%. Comparing base (68a8460) to head (2641dbb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6406   +/-   ##
=======================================
  Coverage   95.08%   95.08%           
=======================================
  Files         576      576           
  Lines       43337    43337           
  Branches     6466     6466           
=======================================
  Hits        41208    41208           
  Misses       2089     2089           
  Partials       40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timreichen timreichen changed the title refactor(cli/unstable): rename ProgressBar end() method to stop() rename(cli/unstable): rename ProgressBar end() method to stop() Feb 15, 2025
@timreichen timreichen changed the title rename(cli/unstable): rename ProgressBar end() method to stop() refactor(cli/unstable): rename ProgressBar end() method to stop() Feb 15, 2025
@kt3k
Copy link
Member

kt3k commented Feb 17, 2025

@BlackAsLight What do you think?

@kt3k kt3k changed the title refactor(cli/unstable): rename ProgressBar end() method to stop() BREAKING(cli/unstable): rename ProgressBar end() method to stop() Feb 17, 2025
@BlackAsLight
Copy link
Contributor

I don't mind the name change

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BlackAsLight
Copy link
Contributor

I think you forgot to merge this pull request?

@kt3k
Copy link
Member

kt3k commented Mar 3, 2025

I'd prefer to keep this and other breaking changes to ProgressBar open for a while to see if there's further feedbacks, and also to not break the usages for every release (ideally I like to merge all breaking changes to ProgressBar at once to minimize the impact of breakage)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants