-
Notifications
You must be signed in to change notification settings - Fork 653
BREAKING(cli/unstable): rename ProgressBar
end()
method to stop()
#6406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
BREAKING(cli/unstable): rename ProgressBar
end()
method to stop()
#6406
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6406 +/- ##
=======================================
Coverage 95.08% 95.08%
=======================================
Files 576 576
Lines 43337 43337
Branches 6466 6466
=======================================
Hits 41208 41208
Misses 2089 2089
Partials 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ProgressBar
end()
method to stop()
ProgressBar
end()
method to stop()
ProgressBar
end()
method to stop()
ProgressBar
end()
method to stop()
@BlackAsLight What do you think? |
ProgressBar
end()
method to stop()
ProgressBar
end()
method to stop()
I don't mind the name change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think you forgot to merge this pull request? |
I'd prefer to keep this and other breaking changes to ProgressBar open for a while to see if there's further feedbacks, and also to not break the usages for every release (ideally I like to merge all breaking changes to ProgressBar at once to minimize the impact of breakage) |
This PR renames
ProgressBar
end()
method tostop()
to align with Spinner.