Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(toml): inline test data #6473

Merged
merged 4 commits into from
Mar 13, 2025
Merged

Conversation

timreichen
Copy link
Contributor

This PR inlines test data. This makes the tests easier to understand and also prevents dead files (like toml/testdata/cargoTest.toml).

@timreichen timreichen requested a review from kt3k as a code owner March 11, 2025 21:12
@github-actions github-actions bot added the toml label Mar 11, 2025
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.68%. Comparing base (d6823ad) to head (7039273).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6473      +/-   ##
==========================================
- Coverage   95.72%   95.68%   -0.04%     
==========================================
  Files         575      575              
  Lines       43192    43192              
  Branches     6471     6475       +4     
==========================================
- Hits        41344    41330      -14     
- Misses       1815     1823       +8     
- Partials       33       39       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iuioiua
Copy link
Contributor

iuioiua commented Mar 12, 2025

Niiice

@kt3k kt3k changed the title refactor(toml): inline test data test(toml): inline test data Mar 13, 2025
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 64690f9 into denoland:main Mar 13, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants