Skip to content

refactor(yaml): refactor directive handler args #6589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

timreichen
Copy link
Contributor

This PR removes the spread args in yamlDirectiveHandler() and tagDirectiveHandler().

@timreichen timreichen requested a review from kt3k as a code owner April 15, 2025 21:09
@github-actions github-actions bot added the yaml label Apr 15, 2025
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.74%. Comparing base (2a059d9) to head (2fafd1c).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
yaml/_loader_state.ts 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6589      +/-   ##
==========================================
+ Coverage   94.54%   94.74%   +0.20%     
==========================================
  Files         580      583       +3     
  Lines       43891    46477    +2586     
  Branches     6501     6523      +22     
==========================================
+ Hits        41496    44034    +2538     
- Misses       2352     2400      +48     
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k
Copy link
Member

kt3k commented Apr 18, 2025

I prefer the existing implementation. The validation of arg count and actual handlings are defined in single place with the current code. Now they are spread into 2 places with this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants