-
Notifications
You must be signed in to change notification settings - Fork 653
feat(collections/unstable): add non-exact binary search function #6628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lionel-rowe
wants to merge
3
commits into
denoland:main
Choose a base branch
from
lionel-rowe:binary-search
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+163
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f54614b
to
4275ba5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6628 +/- ##
=======================================
Coverage 94.74% 94.74%
=======================================
Files 583 584 +1
Lines 46478 46497 +19
Branches 6523 6527 +4
=======================================
+ Hits 44036 44055 +19
Misses 2399 2399
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4275ba5
to
386e808
Compare
kt3k
reviewed
Apr 28, 2025
kt3k
reviewed
Apr 28, 2025
kt3k
reviewed
Apr 28, 2025
kt3k
reviewed
Apr 28, 2025
kt3k
reviewed
Apr 30, 2025
Comment on lines
+7
to
+10
* Binary searching may be preferable to `Array#findIndex` if the array is | ||
* large and performance is at a premium, or if information about the insertion | ||
* index is needed upon non-exact matches (`Array#findIndex` simply returns | ||
* `-1` in such cases). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3069.
Note that this adds a new
binarySearch
function undercollections
, which operates on array-likes of sorted numbers/bigints/strings and implements the same semantics as C#'sArray.BinarySearch
and Java'sArrays.binarySearch
. It doesn't patch the existingBinarySearchTree
underdata-structures
(@WWRS has a separate open PR for that: #6544).