feat(internal): improve format support in node and bun #6630
+153
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6630 +/- ##
==========================================
- Coverage 94.74% 94.73% -0.01%
==========================================
Files 583 583
Lines 46478 46488 +10
Branches 6523 6525 +2
==========================================
+ Hits 44036 44042 +6
- Misses 2399 2402 +3
- Partials 43 44 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
easrng
force-pushed
the
node-bun-format
branch
4 times, most recently
from
2b5b348 to
59c70c3
Compare
kt3k
reviewed
Apr 30, 2025
| assertEquals( | ||
| stripAnsiCode(format({ a: 1, b: 2 })), | ||
| `{ | ||
| if (typeof Deno.inspect === "function") { |
There was a problem hiding this comment.
Can you use ignore option of Deno.test instead of big if block to exclude some tests in some environment? ref https://docs.deno.com/api/deno/~/Deno.TestDefinition
| @@ -73,7 +73,10 @@ import "../../fs/unstable_lstat_test.ts"; | |||
| import "../../fs/unstable_chmod_test.ts"; | |||
| import "../../fs/unstable_umask_test.ts"; | |||
| import "../../fs/unstable_utime_test.ts"; | |||
| import "../../internal/format_test.ts"; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for formatting objects in recent node and bun versions using util.inspect without compromising the experience for users of other runtimes