fix(expect): throw if expect.hasAssertion
and expect.assertions
are not checked
#6646
+244
−78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6518
fixes #6540
Renamed AssertionState to AssertionCounterMoved AssertionCounter fromstd/internal
tostd/expect
: It's really more of anexpect
feature than aninternal
featureThis means thatstd/testing
now depends onstd/expect
RemovedAssertionCounter.#state.assertionTriggered
to avoid desynchronizing fromassertionTriggeredCount
Collected the validation error behavior inAssertionCounter
rather than duplicating it intesting
AssertionState
is reset after validation: fixesexpect.hasAssertion
andexpect.assertions
pollute other assertions tests #6540globalThis
isunload
ed to ensure allAssertionState
s are properly validated and reset: fixesexpect.hasAssertion
andexpect.assertions
silently pass outside bdd tests #6518