Skip to content

fix(expect): throw if expect.hasAssertion and expect.assertions are not checked #6646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

WWRS
Copy link
Contributor

@WWRS WWRS commented May 9, 2025

fixes #6518
fixes #6540

Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 67.50000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 94.81%. Comparing base (c338b2f) to head (eedc630).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/assertion_state.ts 41.66% 7 Missing ⚠️
testing/_test_suite.ts 57.14% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6646      +/-   ##
==========================================
+ Coverage   94.75%   94.81%   +0.06%     
==========================================
  Files         584      574      -10     
  Lines       46563    46439     -124     
  Branches     6541     6528      -13     
==========================================
- Hits        44120    44032      -88     
+ Misses       2400     2364      -36     
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k
Copy link
Member

kt3k commented May 10, 2025

Thank you for the PR! This looks like a nice fix, but I left some comments about code organization.

@WWRS WWRS force-pushed the assertioncounter branch from 7a745aa to 7a3fd9f Compare May 12, 2025 03:39
@WWRS WWRS force-pushed the assertioncounter branch from 7a3fd9f to a654f32 Compare May 12, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants