Skip to content

Conversation

@a-skua
Copy link
Contributor

@a-skua a-skua commented Jan 6, 2026

Summary

  • Rename month constants from abbreviated to full names (e.g., JANJANUARY)
  • Rename weekday constants from abbreviated to full names (e.g., SUNSUNDAY)

Motivation

Addresses feedback from @timreichen in #6910 (comment)

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.22%. Comparing base (c835e4d) to head (5557352).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6939   +/-   ##
=======================================
  Coverage   94.22%   94.22%           
=======================================
  Files         584      584           
  Lines       43146    43146           
  Branches     6908     6908           
=======================================
+ Hits        40653    40656    +3     
+ Misses       2441     2439    -2     
+ Partials       52       51    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@a-skua a-skua marked this pull request as ready for review January 6, 2026 08:13
@a-skua a-skua requested a review from kt3k as a code owner January 6, 2026 08:13
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note to other maintainers: These values haven't been published yet. So this change can be landed as 'refactor'

@kt3k kt3k merged commit ef673ff into denoland:main Jan 8, 2026
19 checks passed
@a-skua a-skua deleted the datetime/constant branch January 8, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants