Skip to content

refactor(http): remove unstable header and method modules#7004

Open
tomas-zijdemans wants to merge 7 commits into
denoland:mainfrom
tomas-zijdemans:remove-headers-and-methods
Open

refactor(http): remove unstable header and method modules#7004
tomas-zijdemans wants to merge 7 commits into
denoland:mainfrom
tomas-zijdemans:remove-headers-and-methods

Conversation

@tomas-zijdemans

@tomas-zijdemans tomas-zijdemans commented Feb 14, 2026

Copy link
Copy Markdown
Contributor

If we want to keep it, then these should be considered for merging instead: #6991 and #6992

@codecov

codecov Bot commented Feb 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.55%. Comparing base (f0c9f14) to head (45c9fbe).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7004      +/-   ##
==========================================
- Coverage   94.57%   94.55%   -0.03%     
==========================================
  Files         636      634       -2     
  Lines       52138    51925     -213     
  Branches     9399     9399              
==========================================
- Hits        49311    49097     -214     
  Misses       2249     2249              
- Partials      578      579       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k

kt3k commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

note: these were originally added in #4317 and #4320

what do people think?

cc @halvardssm

@halvardssm

Copy link
Copy Markdown
Contributor

What is the reasoning for removing them?

I personally find it quite useful to have such headers and other static properties defined in the standard library as it reduces the amount of accidental typos.

Not against keeping them in sync with the IANA registry.

@tomas-zijdemans

Copy link
Copy Markdown
Contributor Author

What is the reasoning for removing them?

Please see the discussion here: https://discord.com/channels/684898665143206084/775393009981849600/1472185311118495796

@tomas-zijdemans

Copy link
Copy Markdown
Contributor Author

Rebased on main

@fibibot fibibot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deletion is clean — no residual HEADER./METHOD. references after the file_server.ts substitutions, and both entries are gone from http/deno.json. The strategic keep-vs-remove question (raised by halvardssm) is the maintainer's call; deferring on that, hence COMMENT not APPROVE.

  • nit: http/mod.ts:29-31 still has the ## Methods section in the module docblock describing the removed module — should be deleted alongside.

tomas-zijdemans and others added 2 commits May 26, 2026 19:15
Co-authored-by: Cursor <cursoragent@cursor.com>
The unstable Methods module was removed in this PR; the corresponding
section in the @std/http module docstring is no longer applicable.

Co-authored-by: Cursor <cursoragent@cursor.com>
@tomas-zijdemans

Copy link
Copy Markdown
Contributor Author

Thanks @fibibot. Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants