refactor(http): remove unstable header and method modules#7004
refactor(http): remove unstable header and method modules#7004tomas-zijdemans wants to merge 7 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7004 +/- ##
==========================================
- Coverage 94.57% 94.55% -0.03%
==========================================
Files 636 634 -2
Lines 52138 51925 -213
Branches 9399 9399
==========================================
- Hits 49311 49097 -214
Misses 2249 2249
- Partials 578 579 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
note: these were originally added in #4317 and #4320 what do people think? cc @halvardssm |
|
What is the reasoning for removing them? I personally find it quite useful to have such headers and other static properties defined in the standard library as it reduces the amount of accidental typos. Not against keeping them in sync with the IANA registry. |
Please see the discussion here: https://discord.com/channels/684898665143206084/775393009981849600/1472185311118495796 |
|
Rebased on main |
fibibot
left a comment
There was a problem hiding this comment.
Deletion is clean — no residual HEADER./METHOD. references after the file_server.ts substitutions, and both entries are gone from http/deno.json. The strategic keep-vs-remove question (raised by halvardssm) is the maintainer's call; deferring on that, hence COMMENT not APPROVE.
- nit:
http/mod.ts:29-31still has the## Methodssection in the module docblock describing the removed module — should be deleted alongside.
Co-authored-by: Cursor <cursoragent@cursor.com>
The unstable Methods module was removed in this PR; the corresponding section in the @std/http module docstring is no longer applicable. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thanks @fibibot. Fixed. |
If we want to keep it, then these should be considered for merging instead: #6991 and #6992