Conversation
|
Related PR with questions has been opened denoland/deno#27762 |
| ], | ||
| "engines": { | ||
| "vscode": "^1.60.0" | ||
| "vscode": "^1.77.0" |
There was a problem hiding this comment.
Does this make a difference to the currently resolved version and is it essential? I'd like to avoid it because the TS plugin API communication has been brittle in the past
There was a problem hiding this comment.
Yes, this bit is essential. It's what is required to get request.continuous and the final argument in
new vscode.TestRunRequest(
runData.request.include,
runData.request.exclude,
runData.request.profile,
true,
),
Without that, we don't have the typings for the continuous run feature in vscode.
I believe that 1.77.0 is also the minimal version bump to get access to said feature.
|
Thank you for merging this! Would you have any suggestions regarding the Deno LSP PR that implements the internal functionality for this? One of my biggest questions was: There's fair bit of code duplication im Deno. The same sort of "run normal" vs "run in watch mode" logic is duplicated here: run_benchmarks Now I did just "exec_with_watch" to the LSP and call it a day, but I feel like there might be a better approach. Any recommendations? |
I wanted a Deno testing experience that's closer to Vitest's UI or Wallaby.js. As in
This now works 🎉
https://github.com/user-attachments/assets/b283b1e1-528f-47d5-b436-86c546d0d3c7
(The execution speed is very slow, because I have not compiled Deno in release mode)
To do so, I had to
Fix #1132