Enable colored output in tests#1298
Merged
nayeemrmn merged 2 commits intodenoland:mainfrom May 29, 2025
Merged
Conversation
Mrashes
reviewed
May 29, 2025
Mrashes
left a comment
Mrashes
left a comment
There was a problem hiding this comment.
Fix makes a lot of sense to me. Not a contributor so can't approve but don't see why this can't be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I disabled the
env["NO_COLOR"]setting for the Deno that is spawned.Instead, since VSCode actually handles ANSI color escapes, I forcibly enable the color setting. The reasoning is that it's entirely possible to start VSCode from the terminal. (e.g. when I configure my git editor to be VSCode, then VSCode gets started from the terminal).
And I do think that it would be confusing if the NO_COLOR terminal setting would affect the test output inside a GUI application.
Since I don't know the full impact of this change: What should I test?
Could this change, for example, break the Deno LSP tests?
Investigation
As far as I can tell from the git blame, the
env["NO_COLOR"]was added 4 years ago, but I couldn't dig up further information as to why.Linked issues
Fixes #1156
Fixes #1267