feat: support github-actions-workflow language#1329
Open
gadicc wants to merge 1 commit intodenoland:mainfrom
Open
feat: support github-actions-workflow language#1329gadicc wants to merge 1 commit intodenoland:mainfrom
gadicc wants to merge 1 commit intodenoland:mainfrom
Conversation
* In `extension.ts`, adds { language: "github-actions-workflow } for
the following schemas: "file", "untitled", "deno". In each cases,
added directly below the related entry for language: "yaml".
* In `package.json`, adds to the `activationEvents` array,
"onLanguage:github-actions-workflow". THE SAME WAS ALSO ADDED
FOR "onLanguage:yaml" which I assume was unintentional.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1170.
In
extension.ts, adds{ language: "github-actions-workflow }for the followingschema:"file","untitled","deno". In each cases, added directly below the related entry for language: "yaml".In
package.json, adds to theactivationEventsarray,"onLanguage:github-actions-workflow". THE SAME WAS ALSO ADDED FOR"onLanguage:yaml"which I assume was left out unintentionally.Based on the same changes for
vscode-yamlat redhat-developer/vscode-yaml#1105.Motivation:
deno fmtalready checks all yaml files (including github actions files) by default. If editing a deno project in vscode, we should be able to edit github actions files in vscode without them failingdeno fmt --checkin CI.