feat: add deno.semanticHighlighting.enabled setting to disable LSP-provided semantic tokens #1347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ovided semantic tokens
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a setting (
deno.semanticHighlighting.enabled) to disable the semantic tokens from the LSP that provide syntax highlighting. The name of the setting was inspired by the built-ineditor.semanticHighlighting.enabled.I added this because the Deno extension completely overrides any extensions that provide their own semantic tokens for parts of a document. Setting this proposed setting to
falsecauses VS Code to use the default Typescript/JavaScript highlighting and allows other extensions to provide semantic tokens while still leaving the other features of this extension enabled.