Skip to content

feat: prompt for custom workspace "deno.path" setting#1356

Merged
dsherret merged 3 commits intodenoland:mainfrom
dsherret:feat_prompt_custom_deno_path_config_setting
Jan 22, 2026
Merged

feat: prompt for custom workspace "deno.path" setting#1356
dsherret merged 3 commits intodenoland:mainfrom
dsherret:feat_prompt_custom_deno_path_config_setting

Conversation

@dsherret
Copy link
Member

@dsherret dsherret commented Jan 22, 2026

It's not ideal that we just execute whatever executable is defined in a workspace "deno.config" setting.

This change adds a prompt when the workspace contains a custom "deno.config" setting (not when the user setting has "deno.config").

  1. Answering "Allow" will be remembered forever by storing it in the workspace vscode state.
  2. Answering "Deny" will be remembered for the current session.
image

@nayeemrmn nayeemrmn changed the title feat: prompt for custom workspace "deno.config" setting feat: prompt for custom workspace "deno.path" setting Jan 22, 2026
Copy link
Collaborator

@nayeemrmn nayeemrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 35d6e14 into denoland:main Jan 22, 2026
2 checks passed
@dsherret dsherret deleted the feat_prompt_custom_deno_path_config_setting branch January 22, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants