-
Notifications
You must be signed in to change notification settings - Fork 1.5k
add option to lint diff buffers #3185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add option to lint diff buffers #3185
Conversation
|
Looks good! Thanks for the patch. We'll need a maintainer to review though. |
|
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
|
@w0rp tests have been written and documentation added. Can we reopen this and get it merged? |
|
@w0rp @Hnasar after using vim-lsp as a standalone for a few years, I'm coming back to using ALE precisely because the error messaging in vim-lsp in diff buffers caused odd jumping around the file. I hadn't realized this was never merged because I had it locally, but if I'm coming back because vim-lsp is insufficient for diff buffers then it doesn't really make sense if it's not supported. Can we reopen and merge this? |
|
Am I missing something here? I don't want to obnoxiously bump, but I also don't want it to get stale. |
|
Another gentle bump |
Adds an option to lint diff buffers as suggested below:
#2583
Tests added, documentation updated.