Skip to content

Conversation

@FouMalade
Copy link
Contributor

This PR fixes the problem with newer versions of Proselint by using the output of the --version command.

Fixes #5042

@Nytelife26
Copy link

Nytelife26 commented Dec 5, 2025

Thank you for taking the time to update this. Following a conversation in amperser/proselint#1451, we were considering re-adding --version as an alias to proselint version for backwards compatibility, but I realise this breaks the fundamental assumption upon which your PR rests.

Since I am not familiar with ALE internals, I have some questions: How is this handled for other applications? Are there facilities for parsing the output of --version if we were to go ahead with putting it back? Would it be preferable to add a version key to the JSON output? Or is it ultimately easiest to just leave --version out at this point?

Update: I have a potential resolution to this. --output-format json did not exist prior to 0.16. Therefore, you can use proselint version --output-format json instead of proselint --version, and if that succeeds, you're on 0.16+.

@FouMalade
Copy link
Contributor Author

I’m not familiar with ALE’s internals either, but the solution you propose using proselint version --output-format json instead of proselint --version works for me, and I can adapt to that.

@FouMalade FouMalade force-pushed the fix-proselint branch 3 times, most recently from e3cdf65 to d715aa2 Compare December 5, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upcoming proselint release requires new "check" verb

3 participants