feat(nagelfar): Support file name prefix in regex#5141
Open
MayeulC wants to merge 2 commits into
Open
Conversation
This allows adding a header file containing custom definitions to tcl_nagelfar_otions. Nagelfar can generate such headers with: nagelfar -header file_name <input tcl files>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows adding a header file containing custom definitions to tcl_nagelfar_otions.
Nagelfar can generate such headers with:
nagelfar -header file_name
Note that the file name displayed is the path that is passed as a parameter to nagelfar.
I tested the change, it works both with an extra header and without.
I have added a test, but:
fileor useale#test#SetFilename('def.tcl')+ale#test#GetFilename('def.tcl')Edit: I only have access to the web GitHub UI right now, and I committed the test to the wrong branch. Fixed, but this cancelled the workflow.