Skip to content

Conversation

@bubu11e
Copy link
Contributor

@bubu11e bubu11e commented Oct 7, 2025

This commit add the support for prometheus native histogram in place of classic histograms See: https://prometheus.io/docs/specs/native_histograms/

This feature is still experimental so disabled by default.

@depado
Copy link
Owner

depado commented Oct 8, 2025

Hi!
Looks amazing thanks a lot for your PR! 🎉
Sorry for the CI fail on the test/coverage, I've fixed the permission issue if you can rebase your branch 🙏
Otherwise there's just an ineffective assignment in the tests, but that looks good to me once this is fixed

@bubu11e bubu11e force-pushed the enable_native_histogram branch from f520844 to f753942 Compare October 8, 2025 09:56
@bubu11e
Copy link
Contributor Author

bubu11e commented Oct 8, 2025

Hi, thanks for your quick answer. Could you hint me where this ineffective assignment is ?

@bubu11e bubu11e force-pushed the enable_native_histogram branch from f753942 to b8ecd1c Compare October 8, 2025 13:27
Copy link
Owner

@depado depado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things about error handling in the tests and then we're good!

This commit add the support for prometheus native histogram in place of classic histograms
See: https://prometheus.io/docs/specs/native_histograms/

This feature is still experimental so disabled by default.

Signed-off-by: julien.girard <[email protected]>
@bubu11e bubu11e force-pushed the enable_native_histogram branch from b8ecd1c to e7054f6 Compare October 8, 2025 14:19
@bubu11e bubu11e requested a review from depado October 8, 2025 14:28
@depado depado merged commit 51498ff into depado:main Oct 8, 2025
4 checks passed
@depado
Copy link
Owner

depado commented Oct 8, 2025

v1.8.2 is out now with your feature included 😄

Thanks a lot!

@bubu11e
Copy link
Contributor Author

bubu11e commented Oct 8, 2025

Thanks a lot, have a nice day !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants