Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clickable Links in User Content (Variation B) #2687

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Clickable Links in User Content (Variation B) #2687

wants to merge 7 commits into from

Conversation

mgaoVA
Copy link
Collaborator

@mgaoVA mgaoVA commented Mar 1, 2025 •
edited
Loading

See #2686

This variant triggers the feature from individual data fields. It requires less overall code and has more forward compatibility, at the cost of having a higher chance of impacting field-developed code.

This variant is likely to be preferred, pending discussion.

@mgaoVA mgaoVA mentioned this pull request Mar 3, 2025
Open
@mgaoVA
resolve scoping issue in chromium based browsers
7f79521 
Issue can be reproduced by observing the Inbox -> Quick View for requests that contain allowed URLs

Might need to implement ready handler
shaneodd
shaneodd approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@shaneodd shaneodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say since this keeps things simpler even though it could nudge field code a bit. I think this may be the better option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneodd shaneodd shaneodd approved these changes

@Pelentan Pelentan Awaiting requested review from Pelentan Pelentan will be requested when the pull request is marked ready for review Pelentan is a code owner

@aerinkayne aerinkayne Awaiting requested review from aerinkayne aerinkayne will be requested when the pull request is marked ready for review aerinkayne is a code owner

@pete-nerantzinis pete-nerantzinis Awaiting requested review from pete-nerantzinis pete-nerantzinis will be requested when the pull request is marked ready for review pete-nerantzinis is a code owner

@jampaul3 jampaul3 Awaiting requested review from jampaul3 jampaul3 will be requested when the pull request is marked ready for review jampaul3 is a code owner

@nk2136 nk2136 Awaiting requested review from nk2136 nk2136 will be requested when the pull request is marked ready for review nk2136 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgaoVA @shaneodd