Skip to content
This repository is currently being migrated. It's locked while the migration is in progress.

LEAF 5690 smarty sourced from app only#2902

Open
aerinkayne wants to merge 4 commits into
masterfrom
issue/LEAF-5690/smarty_from_app_only
Open

LEAF 5690 smarty sourced from app only#2902
aerinkayne wants to merge 4 commits into
masterfrom
issue/LEAF-5690/smarty_from_app_only

Conversation

@aerinkayne
Copy link
Copy Markdown
Contributor

Summary

Files associated with the Smarty template engine are present in both libs and app/libs.

This change updates the path used by the leaf_autoloader to use the app version and removes the libs version.
The include statements associated with the registration of 2 methods from XSSHelpers.php have also been updated for consistency and to remove a remaining reference to an older XXSHelpers location in PHP Commons. These changes are intended to improve maintainability

Impact

No expected impact

Testing

Regression testing.
No new functionality has been added

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 9, 2026

Static Code Analysis Summary

Date: $(date)
Branch: 2902/merge
Commit: c7ebb59
Triggered by: pull_request

Analysis Results

PHP Analysis

  • PHPStan and Psalm reports available in artifacts

JavaScript/TypeScript Analysis

  • ESLint security and quality checks completed

Go Analysis

  • Gosec security scanning completed
  • Staticcheck analysis completed

HTML Analysis

  • HTMLHint validation completed

Security Scan

  • Semgrep multi-language security analysis completed
  • SARIF report uploaded to GitHub Security tab

Viewing Reports

All detailed reports are available as workflow artifacts and will be retained for 30 days.

Security findings can be viewed in the Security tab under Code scanning alerts.


Note: This scan is informational only and does not block merges.

@aerinkayne aerinkayne marked this pull request as draft March 9, 2026 19:57
@aerinkayne aerinkayne marked this pull request as ready for review March 18, 2026 20:52
Copy link
Copy Markdown

@mflynn-sierra7 mflynn-sierra7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you did this. It looks clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants