This repository is currently being migrated. It's locked while the migration is in progress.
LEAF 5690 smarty sourced from app only#2902
Open
aerinkayne wants to merge 4 commits into
Open
Conversation
Static Code Analysis SummaryDate: $(date) Analysis ResultsPHP Analysis
JavaScript/TypeScript Analysis
Go Analysis
HTML Analysis
Security Scan
Viewing ReportsAll detailed reports are available as workflow artifacts and will be retained for 30 days. Security findings can be viewed in the Security tab under Code scanning alerts. Note: This scan is informational only and does not block merges. |
jampaul3
approved these changes
Mar 19, 2026
mflynn-sierra7
approved these changes
Mar 20, 2026
mflynn-sierra7
left a comment
There was a problem hiding this comment.
Glad you did this. It looks clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Files associated with the Smarty template engine are present in both libs and app/libs.
This change updates the path used by the leaf_autoloader to use the app version and removes the libs version.
The include statements associated with the registration of 2 methods from XSSHelpers.php have also been updated for consistency and to remove a remaining reference to an older XXSHelpers location in PHP Commons. These changes are intended to improve maintainability
Impact
No expected impact
Testing
Regression testing.
No new functionality has been added