This repository is currently being migrated. It's locked while the migration is in progress.
LEAF-5792 - isSafeSqlIdentifier not accepting url with period#2912
Draft
shaneodd wants to merge 2 commits into
Draft
LEAF-5792 - isSafeSqlIdentifier not accepting url with period#2912shaneodd wants to merge 2 commits into
shaneodd wants to merge 2 commits into
Conversation
Static Code Analysis SummaryDate: $(date) Analysis ResultsPHP Analysis
JavaScript/TypeScript Analysis
Go Analysis
HTML Analysis
Security Scan
Viewing ReportsAll detailed reports are available as workflow artifacts and will be retained for 30 days. Security findings can be viewed in the Security tab under Code scanning alerts. Note: This scan is informational only and does not block merges. |
…ater. did not want to leave it as is
Static Code Analysis SummaryDate: $(date) Analysis ResultsPHP Analysis
JavaScript/TypeScript Analysis
Go Analysis
HTML Analysis
Security Scan
Viewing ReportsAll detailed reports are available as workflow artifacts and will be retained for 30 days. Security findings can be viewed in the Security tab under Code scanning alerts. Note: This scan is informational only and does not block merges. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add in period as an acceptable identifier
Impact
Issues with queries on sites with periods in the url
Testing
Go to a site with period in url, then attempt to add yourself to admin and view the admin area.