Check GIT_COMMIT availability before falling back to CLI#153
Open
lindluni wants to merge 8 commits into
Open
Conversation
lindluni
force-pushed
the
git-commit-fallback
branch
from
5acebb1 to
5a7c8c1
Compare
Signed-off-by: Brett Logan <lindluni@github.com>
Signed-off-by: Brett Logan <lindluni@github.com>
Signed-off-by: Brett Logan <9400927+lindluni@users.noreply.github.com>
lindluni
force-pushed
the
git-commit-fallback
branch
from
c2dc8ae to
9af3628
Compare
Signed-off-by: Brett Logan <9400927+lindluni@users.noreply.github.com>
lindluni
force-pushed
the
git-commit-fallback
branch
from
d8ee9b5 to
16e726e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small improvement to the
ExecuteCodeQL.groovyscript by enhancing the logic for determining the commit hash when uploading SARIF files.Enhancements to commit determination:
jenkins/shared-libraries/linux/vars/ExecuteCodeQL.groovy: Added a conditional check to prioritize theGIT_COMMITenvironment variable for determining the commit hash. IfGIT_COMMITis not set, the script falls back to usinggit rev-parse HEAD. This ensures more robust and explicit commit identification during SARIF file uploads.