-
Notifications
You must be signed in to change notification settings - Fork 13
va-pagination: update for maximum of seven slots #1476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 14 commits
e7ece77
2fcec36
06efa84
0821778
39ab503
ff05f59
68c8926
f6a8145
db09b81
aca4288
8b747eb
5e57916
014a83a
55e0362
02a20d3
abc397c
5b51cff
8730cea
009dfa3
4b4bc7a
61b55e4
937c86f
330beb4
7236bb7
3388b43
714a2a9
605599d
186dabc
8f5b4a2
41cc266
67a6e5d
0aba699
5ca3781
19f2ee6
bad5b12
e3374bf
f315ef6
0f31859
9d7054a
cafec25
433878d
9cc3dca
9c4f99d
0c94077
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,7 @@ | |
:host { | ||
background-color: var(--vads-color-white); | ||
border-top: 1px solid var(--vads-color-base-lightest); | ||
container-type: inline-size; | ||
display: flex; | ||
font-family: var(--font-source-sans); | ||
justify-content: center; | ||
|
@@ -55,3 +56,9 @@ button { | |
transition: all 0.3s ease-in-out; | ||
transition-property: color, background-color; | ||
} | ||
|
||
@container (max-width: 640px) { // Variables won't compile. Matching TSX file for now. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
What does this mean? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was having quite a time passing the USWDS There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's really interesting 🤔 I wonder if that's a Stencil limitation? Thanks for explaining! Do you mind just mentioning in the comment that the value is for the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it's a limitation in Sass. I found this article Want CSS variables in media query declarations? Try this! that digs into the specifics of Sass variables in media and container queries. I'll update the comment explaining the issue. |
||
.usa-pagination__overflow { | ||
margin: 0; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like these
setViewport
tests!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😮 Wow, this is awesome! Can we add or update mobile to be 320px and still run these tests? That's a iPhone SE (1st gen) resolution and the size we currently design mobile assets for.