-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to Storybook for VA Mobile components #1499
base: main
Are you sure you want to change the base?
Conversation
}); | ||
|
||
export const Button = ({ text, onPress, color, textColor }: ButtonProps) => ( | ||
<View style={styles.buttonContainer}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a simple react-native button to demonstrate that it renders in Storybook. We can remove this file after the discovery work is complete.
@@ -0,0 +1,96 @@ | |||
import { StorybookConfig } from "@storybook/react-webpack5"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this file (essentially the Storybook webpack build) to .ts
so that we could use this StorybookConfig
type which has helped to ferret out a few incorrect settings.
(Story) => ( | ||
<View | ||
style={{ | ||
flex: 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Storybook file was moved from va-mobile-library repo so it's a 1:1 of that file except that we are importing the button from the NPM package.
import './style.scss'; | ||
import '@department-of-veterans-affairs/formation/dist/formation'; | ||
// import '@department-of-veterans-affairs/formation/dist/formation'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chromatic
https://3716-mobile-storybook--65a6e2ed2314f7b8f98609d8.chromatic.com
Description
Complete discovery document here: https://vfs.atlassian.net/wiki/spaces/DST/pages/3872882700/Discovery+Integrating+mobile+components+into+VADS+Storybook
related department-of-veterans-affairs/vets-design-system-documentation#3716
QA Checklist
Screenshots
Acceptance criteria
Definition of done