Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox aria checked #1514

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Checkbox aria checked #1514

wants to merge 4 commits into from

Conversation

rsmithadhoc
Copy link
Contributor

@rsmithadhoc rsmithadhoc commented Mar 7, 2025

Chromatic

https://checkbox-aria-checked--65a6e2ed2314f7b8f98609d8.chromatic.com


Description

Closes department-of-veterans-affairs/vets-design-system-documentation#3807

aria-checked was not being set on the HTML attribute despite evaluating to false. I added a condition to set this to null and that removes the attribute as expected when it is unchecked.

QA Checklist

  • Component maintains 1:1 parity with design mocks
  • Text is consistent with what's been provided in the mocks
  • Component behaves as expected across breakpoints
  • Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
  • Designer has signed off on changes (if applicable. If not applicable provide reason why)
  • Tab order and focus state work as expected
  • Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
  • New components are covered by e2e tests; updates to existing components are covered by existing test suite
  • Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Screenshots

image

Acceptance criteria

  • QA checklist has been completed
  • Screenshots have been attached that cover desktop and mobile screens

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue

@rsmithadhoc rsmithadhoc added the patch Patch change in semantic versioning label Mar 7, 2025
@rsmithadhoc rsmithadhoc marked this pull request as ready for review March 7, 2025 17:03
@rsmithadhoc rsmithadhoc requested a review from a team as a code owner March 7, 2025 17:03
Copy link
Contributor

@powellkerry powellkerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch change in semantic versioning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DST Staging Review: Wrong aria-checked value when no checkboxes checked
2 participants