Skip to content
This repository is currently being migrated. It's locked while the migration is in progress.

Workflows: improve efficiency of yarn install#1918

Draft
powellkerry wants to merge 22 commits into
mainfrom
workflow-improvements
Draft

Workflows: improve efficiency of yarn install#1918
powellkerry wants to merge 22 commits into
mainfrom
workflow-improvements

Conversation

@powellkerry
Copy link
Copy Markdown
Contributor

@powellkerry powellkerry commented Dec 10, 2025

Chromatic

https://workflow-improvements--65a6e2ed2314f7b8f98609d8.chromatic.com

Description

This pull request updates several GitHub Actions workflows to use newer versions of key actions and streamlines the dependency installation process. The main improvements focus on upgrading action versions for better reliability and security, and simplifying how dependencies are installed across jobs.

Workflow action upgrades:

  • Updated all usages of actions/checkout from version 2 to version 4 for improved performance and security across .github/workflows/chromatic.yml, .github/workflows/node.js.yml, .github/workflows/publish-storybook.yml, and .github/workflows/publish.yml. [1] [2] [3] [4]
  • Updated all usages of actions/setup-node from version 3 to version 4 to ensure compatibility with the latest Node.js features and security patches. [1] [2] [3] [4]
  • Updated aws-actions/configure-aws-credentials from version 1 to version 2 in .github/workflows/publish-storybook.yml.

Dependency installation improvements:

  • Replaced multiple yarn install steps with a single yarn install --immutable step in all workflows, ensuring that the lockfile is strictly followed and reducing redundant installs in subdirectories. [1] [2] [3] [4] [5]
  • Removed unnecessary repeated installs in package subdirectories, simplifying workflow steps and speeding up CI runs. [1] [2] [3] [4]

Testing and build process simplification:

  • Updated test and build steps to run directly after dependency installation, removing redundant install commands before running tests or builds in package directories. [1] [2] [3] [4]

These changes help keep workflows up-to-date, more maintainable, and faster.

Related tickets and links

Closes

Screenshots

Testing and review

Approvals

See the QA Checklists section below for suggested approvals. Use your best judgment if additional reviews are needed. When in doubt, request a review.

Approval groups

Add approval groups to the PR as needed:

QA checklists

Use the QA checklists below as guides, not rules. Not all checklists will apply to every PR but there could be some overlap.

In all scenarios, changes should be fully tested by the author and verified by the reviewer(s); functionality, responsiveness, etc.

✨ New Component Added
  • The PR has the minor label
  • The component matches the Figma designs.
  • All properties, custom events, and utility functions have e2e and/or unit tests
  • A new Storybook page has been added for the component
  • Tested in all VA breakpoints.
  • Chromatic UI Tests have run and snapshot changes have been accepted by the design reviewer
  • Tested in vets-website using Verdaccio
  • Engineering has approved the PR
  • Design has approved the PR
  • Accessibility has approved the PR
🌱 New Component Variation Added
  • The PR has the minor label
  • The variation matches its Figma design.
  • Any new properties, custom events, or utility functions have e2e and/or unit tests
  • A new story has been added to the component's existing Storybook page
  • Any Chromatic UI snapshot changes have been accepted by a design reviewer
  • Tested in vets-website using Verdaccio
  • Engineering has approved the PR
  • Design has approved the PR
🐞 Component Fix
  • The PR has the patch label
  • Any new properties, custom events, or utility functions have e2e and/or unit tests
  • Any markup changes are evaluated for impact on vets-website.
    • Will any vets-website tests fail from the change?
  • Any Chromatic UI snapshot changes have been reviewed and approved by a designer if necessary
  • Engineering has approved the PR
♿️ Component Fix - Accessibility
  • The PR has the patch label
  • Any new properties, custom events, or utility functions have e2e and/or unit tests
  • Any Chromatic UI snapshot changes have been reviewed and approved by a designer if necessary
  • Engineering has approved the PR
  • Accessibility has approved the PR
🚨 Component Fix - Breaking API Change
  • The PR has the major label
  • vets-website and content-build have been evaluated to determine the impact of the breaking change
  • Any new properties, custom events, or utility functions have e2e and/or unit tests
  • Any Chromatic UI snapshot changes have been reviewed and approved by a designer if necessary
  • Tested in vets-website using Verdaccio
  • Engineering has approved the PR
🔧 Component Update - Non-Breaking API Change
  • The PR has the minor label
  • Any new properties, custom events, or utility functions have e2e and/or unit tests
  • Any Chromatic UI snapshot changes have been reviewed and approved by a designer if necessary
  • Engineering has approved the PR
📖 Storybook Update
  • The PR has the ignore-for-release label
  • Any Chromatic UI snapshot changes have been reviewed and approved by a designer if necessary
  • Engineering has approved the PR
🎨 CSS-Library Update
  • The PR has the css-library label
  • vets-website and content-build have been checked to determine the impact of any breaking changes
  • Engineering has approved the PR

@powellkerry powellkerry added ignore-for-release Used if you want to ignore the PR in the generated release notes run chromatic workflow Allows a PR to run the chromatic workflow to deploy Chromatic without "ready for review" status. labels Dec 10, 2025
Comment thread .github/workflows/node.js.yml Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release Used if you want to ignore the PR in the generated release notes run chromatic workflow Allows a PR to run the chromatic workflow to deploy Chromatic without "ready for review" status.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants