Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-18065: Adds fieldLastSavedByAnEditor to entities for sitemap. #2126

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

dsasser
Copy link
Contributor

@dsasser dsasser commented Jun 11, 2024

Summary

  • Adds the fieldLastSavedByAnEditor to Drupal entity pages queries to allow this date to make its way to the sitemap. The corresponding change to incorporate this field into the sitemap has already been made, this PR just adds the field to existing GraphQL queries that reflect nodes with this field present.

Related issue(s)

Relates to: department-of-veterans-affairs/va.gov-cms#16333

Testing done

  • Tested that new sitemap reflects the field_last_saved_by_an_editor value for a sampling of nodes

What areas of the site does it impact?

Sitemap
GraphQL queries for Drupal detail pages

QA

All testing to be perfomred on this Tugboat, not the RI on this PR.

Nodes Last Changed By A Script:

Type Node ID Changed Editor Last Changed
Event 43137 Oct 12, 2022 Oct. 17 2022
News Story 49700 Oct. 12 2022 Oct. 17 2022

Nodes Last Changed By An Editor:

Type Node ID Changed Editor Last Changed
Page 2 Oct. 12 2022 Jun. 13 2019
Person Profile 7742 Oct. 13 2022 Jun. 13 2019
VA Form 5694 Jun. 12 2023 Sep. 17 2020
Event 20103 Oct. 13 2022 Jun. 23 2022
News Story 377 Oct. 13 2022 Nov. 12 2019

Test Steps:
Using each of the above nodes, confirm that the 'Editor Last Changed' date matches in the sitemap (you will need to use the browser's find tool to search for the path to the node)

For instance, the first node, 43137, has a path of '/wichita-health-care/events/43137'. Searching for this page reveals a 'lastmod' entry of 2022-10-17 which matches the date in the 'Editor Last Changed' column for this node. The formatting of the date is not expected to match.

Screenshot 2024-06-18 at 7 48 09 AM Screenshot 2024-06-18 at 7 52 46 AM

Acceptance criteria

  • Content-build build succeeds (tests that graphql changes haven't broken the build)
  • Sitemap entires for test nodes (above) have expected values.

Copy link
Contributor

@randimays randimays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there was a copy/paste error in the table in the description. This node (https://main-ssvjwnze6ybgmnncgodvaj7rot8qtxfe.demo.cms.va.gov/gulf-coast-health-care/staff-profiles/michael-d-payne-jr) was last edited 3/31/2021. It reflects correctly in the sitemap based on the CMS data though 👍🏻

Screenshot 2024-06-18 at 11 28 06 AM

LGTM!

Copy link
Contributor

@chriskim2311 chriskim2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dsasser dsasser merged commit cc769cd into main Jun 18, 2024
24 checks passed
@dsasser dsasser deleted the VACMS-18065-add-last-saved-for-sitemap branch June 18, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants