Integration form engine 2 #2273

ryguyk · 2024-09-16T16:04:32Z

Summary

This is an integration branch tracking work on the Form Engine product. All the individual PRs listed below have been reviewed and approved prior to merging into this integration branch. This branch is now ready for review and merging.

Individual PRs:

Related issue(s)

See individual PRs.

Testing done

See individual PRs.

Screenshots

See individual PRs.

What areas of the site does it impact?

See individual PRs. In short, this work applies to a KISS file.

Acceptance criteria

Quality Assurance & Testing

I fixed|updated|added unit tests and integration tests for each feature (if applicable).
No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
Linting warnings have been addressed
Documentation has been updated (link to documentation *if necessary)
Screenshot of the developed feature is added
Accessibility testing has been performed

Error Handling

Browser console contains no warnings or errors.
Events are being sent to the appropriate logging solution
Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

Did you login to a local build and verify all authenticated routes work as expected with a test user

* Create postProcessDigitalForm function * Add nameAndDateOfBirth fragment * Create digitalForm GraphQL fragment * Import nameAndDateOfBirth into digitalForm fragment * Create digitalForm query object * Import digitalForm fragment into query object * Export postProcessDigitalForm as postProcess * Add Digital Forms to DATA_FILES array * Fix module imports * Fix typo * Adds blank line for consistent spacing. --------- Co-authored-by: Ryan Koch <[email protected]>

* Add normalizeForms step to postProcessDigitalForm * Add subtitle to normalized form * Add OMB Number to normalized form * Normalize chapters for each form * Add additional fields for Name and Date of Birth step * Fix import spec * Remove redundant JSON parsing * Remove JSON conversion from returned value * Add formID and rename id to cmsId * Remove subTitle * Refactor normalizeForms method * Refactor normalizeChapters * Defend against malformed query responses * Remove unused import

* Add OMB info to Digital Form GraphQL query * Normalize OMB info * Remove Date object from formatDate

va-vfs-bot

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

va-vfs-bot · 2024-09-16T16:05:05Z

src/site/stages/build/drupal/static-data-files/config.unit.spec.js

@@ -0,0 +1,15 @@
+/* eslint-disable @department-of-veterans-affairs/axe-check-required */


ESLint disabled here

va-vfs-bot · 2024-09-16T16:05:05Z

...stages/build/drupal/static-data-files/digitalForm/fragments/digitalForm.graphql.unit.spec.js

@@ -0,0 +1,26 @@
+/* eslint-disable @department-of-veterans-affairs/axe-check-required */


ESLint disabled here

va-vfs-bot · 2024-09-16T16:05:06Z

...build/drupal/static-data-files/digitalForm/fragments/nameAndDateOfBirth.graphql.unit.spec.js

@@ -0,0 +1,14 @@
+/* eslint-disable @department-of-veterans-affairs/axe-check-required */


ESLint disabled here

va-vfs-bot · 2024-09-16T16:05:06Z

src/site/stages/build/drupal/static-data-files/digitalForm/index.unit.spec.js

@@ -0,0 +1,52 @@
+/* eslint-disable @department-of-veterans-affairs/axe-check-required */


ESLint disabled here

va-vfs-bot · 2024-09-16T16:05:06Z

src/site/stages/build/drupal/static-data-files/digitalForm/postProcessDigitalForm.unit.spec.js

@@ -0,0 +1,180 @@
+/* eslint-disable @department-of-veterans-affairs/axe-check-required */


ESLint disabled here

va-vfs-bot

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

va-vfs-bot · 2024-09-18T15:44:54Z

...rupal/static-data-files/digitalForm/fragments/identificationInformation.graphql.unit.spec.js

@@ -0,0 +1,15 @@
+/* eslint-disable @department-of-veterans-affairs/axe-check-required */


ESLint disabled here

* Create postProcessDigitalForm function * Add nameAndDateOfBirth fragment * Create digitalForm GraphQL fragment * Import nameAndDateOfBirth into digitalForm fragment * Create digitalForm query object * Import digitalForm fragment into query object * Export postProcessDigitalForm as postProcess * Add Digital Forms to DATA_FILES array * Fix module imports * Fix typo * Adds blank line for consistent spacing. --------- Co-authored-by: Ryan Koch <[email protected]>

* Add normalizeForms step to postProcessDigitalForm * Add subtitle to normalized form * Add OMB Number to normalized form * Normalize chapters for each form * Add additional fields for Name and Date of Birth step * Fix import spec * Remove redundant JSON parsing * Remove JSON conversion from returned value * Add formID and rename id to cmsId * Remove subTitle * Refactor normalizeForms method * Refactor normalizeChapters * Defend against malformed query responses * Remove unused import

…-engine-2

…ation-form-engine-2

Normalizes the Address Paragraph type.

va-vfs-bot

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

va-vfs-bot · 2024-10-04T20:02:15Z

...ite/stages/build/drupal/static-data-files/digitalForm/fragments/address.graphql.unit.spec.js

@@ -0,0 +1,13 @@
+/* eslint-disable @department-of-veterans-affairs/axe-check-required */


ESLint disabled here

Strip the "Digital Form: " prefix out of our content-build output. Move all digital form tests to a tests directory and extract the test entities into fixture files.

va-vfs-bot

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

va-vfs-bot · 2024-10-09T16:39:17Z

...ages/build/drupal/static-data-files/digitalForm/tests/fragments/address.graphql.unit.spec.js

@@ -0,0 +1,13 @@
+/* eslint-disable @department-of-veterans-affairs/axe-check-required */


ESLint disabled here

va-vfs-bot · 2024-10-09T16:39:17Z

...static-data-files/digitalForm/tests/fragments/identificationInformation.graphql.unit.spec.js

@@ -0,0 +1,15 @@
+/* eslint-disable @department-of-veterans-affairs/axe-check-required */


ESLint disabled here

va-vfs-bot · 2024-10-09T16:39:17Z

src/site/stages/build/drupal/static-data-files/digitalForm/tests/index.unit.spec.js

@@ -0,0 +1,23 @@
+/* eslint-disable @department-of-veterans-affairs/axe-check-required */


ESLint disabled here

va-vfs-bot · 2024-10-09T16:39:18Z

.../stages/build/drupal/static-data-files/digitalForm/tests/postProcessDigitalForm.unit.spec.js

@@ -0,0 +1,144 @@
+/* eslint-disable @department-of-veterans-affairs/axe-check-required */


ESLint disabled here

…2308) Normalizes the Phone and Email Address Paragraph type.

va-vfs-bot

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

va-vfs-bot · 2024-10-16T18:00:16Z

.../build/drupal/static-data-files/digitalForm/tests/fragments/digitalForm.graphql.unit.spec.js

@@ -0,0 +1,33 @@
+/* eslint-disable @department-of-veterans-affairs/axe-check-required */


ESLint disabled here

va-vfs-bot · 2024-10-16T18:00:16Z

...uild/drupal/static-data-files/digitalForm/tests/fragments/phoneAndEmail.graphql.unit.spec.js

@@ -0,0 +1,14 @@
+/* eslint-disable @department-of-veterans-affairs/axe-check-required */


ESLint disabled here

Normalizes the "Your personal information" Paragraph type.

va-vfs-bot

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

va-vfs-bot · 2024-11-04T16:19:33Z

...l/static-data-files/digitalForm/tests/fragments/yourPersonalInformation.graphql.unit.spec.js

@@ -0,0 +1,13 @@
+/* eslint-disable @department-of-veterans-affairs/axe-check-required */


ESLint disabled here

Normalizes the List & Loop Paragraph type.

va-vfs-bot

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

va-vfs-bot · 2024-11-12T17:46:43Z

...ges/build/drupal/static-data-files/digitalForm/tests/fragments/listLoop.graphql.unit.spec.js

@@ -0,0 +1,14 @@
+/* eslint-disable @department-of-veterans-affairs/axe-check-required */


ESLint disabled here

derekhouck and others added 6 commits September 11, 2024 21:28

Add OMB info to Digital Form GraphQL query

49ce1af

Normalize OMB info

0cec642

Remove Date object from formatDate

4d7dc20

VATEAM-90733: Normalize OMB info fields (#2252)

52edb57

* Add OMB info to Digital Form GraphQL query * Normalize OMB info * Remove Date object from formatDate

va-vfs-bot requested a review from a team September 16, 2024 16:05

va-vfs-bot reviewed Sep 16, 2024

View reviewed changes

derekhouck added 4 commits September 16, 2024 14:07

Add Identification Information fragment

b64c733

Import identificationInformation fragment into digitalForm fragment

62fdaab

Extract Identification Information fields

ee1a69f

Fix imports

9a6014e

va-vfs-bot reviewed Sep 18, 2024

View reviewed changes

derekhouck and others added 2 commits September 18, 2024 10:45

ryguyk force-pushed the integration-form-engine-2 branch from 195a33f to e3d84e6 Compare September 18, 2024 15:46

va-vfs-bot deployed to master/main/integration-form-engine-poc September 18, 2024 16:03 View deployment

va-vfs-bot temporarily deployed to master/main/integration-form-engine-2 September 18, 2024 16:03 Inactive

va-vfs-bot temporarily deployed to master/main/integration-form-engine-2 September 20, 2024 19:07 Inactive

derekhouck added 3 commits October 2, 2024 10:36

Merge branch 'main' into integration-form-engine-2

a314931

Merge branch '90733-normalize-omb-info-section' into integration-form…

3633329

…-engine-2

Merge branch '91741-normalize-identification-information' into integr…

628f6cb

…ation-form-engine-2

va-vfs-bot temporarily deployed to master/main/integration-form-engine-2 October 2, 2024 16:07 Inactive

VATEAM-92265: Normalize Address Digital Form pattern output (#2301)

0166a12

Normalizes the Address Paragraph type.

va-vfs-bot reviewed Oct 4, 2024

View reviewed changes

va-vfs-bot temporarily deployed to master/main/integration-form-engine-2 October 4, 2024 20:14 Inactive

VATEAM-94290: Remove "Digital Form:" from content-build output (#2304)

02d5d12

Strip the "Digital Form: " prefix out of our content-build output. Move all digital form tests to a tests directory and extract the test entities into fixture files.

va-vfs-bot reviewed Oct 9, 2024

View reviewed changes

va-vfs-bot temporarily deployed to master/main/integration-form-engine-2 October 9, 2024 17:13 Inactive

Merge branch 'main' into integration-form-engine-2

1d80dde

va-vfs-bot temporarily deployed to master/main/integration-form-engine-2 October 16, 2024 14:57 Inactive

VATEAM-93401: Normalize Phone and Email Digital Form pattern output (#…

a0310be

…2308) Normalizes the Phone and Email Address Paragraph type.

va-vfs-bot reviewed Oct 16, 2024

View reviewed changes

va-vfs-bot temporarily deployed to master/main/integration-form-engine-2 October 16, 2024 18:31 Inactive

VATEAM-94709: Normalize Your Personal Information chapter (#2338)

00433c4

Normalizes the "Your personal information" Paragraph type.

va-vfs-bot reviewed Nov 4, 2024

View reviewed changes

va-vfs-bot deployed to master/main/integration-form-engine-2 November 4, 2024 16:57 View deployment

va-vfs-bot temporarily deployed to master/main/93614-normalize-list-and-loop November 8, 2024 16:01 Inactive

VATEAM-93614: Normalize List and Loop pattern output (#2350)

56aee27

Normalizes the List & Loop Paragraph type.

va-vfs-bot reviewed Nov 12, 2024

View reviewed changes

va-vfs-bot had a problem deploying to master/main/integration-form-engine-2 November 12, 2024 17:51 Error

derekhouck marked this pull request as ready for review January 22, 2025 16:39

derekhouck requested review from a team as code owners January 22, 2025 16:39

Merge branch 'main' into integration-form-engine-2

c4b5e09

va-vfs-bot had a problem deploying to master/main/integration-form-engine-2 January 22, 2025 16:53 Error

va-vfs-bot had a problem deploying to master/main/98086-draft-forms January 22, 2025 16:54 Error

ryguyk changed the title ~~DNM: Integration form engine 2~~ Integration form engine 2 Jan 22, 2025

ryguyk requested a review from derekhouck January 22, 2025 17:53

timcosgrove approved these changes Jan 22, 2025

View reviewed changes

derekhouck approved these changes Jan 22, 2025

View reviewed changes

va-vfs-bot had a problem deploying to master/main/98086-draft-forms January 22, 2025 19:11 Error

derekhouck merged commit 1444f74 into main Jan 22, 2025
36 of 39 checks passed

derekhouck deleted the integration-form-engine-2 branch January 22, 2025 20:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integration form engine 2 #2273

Integration form engine 2 #2273

ryguyk commented Sep 16, 2024 •

edited

Loading

va-vfs-bot left a comment

va-vfs-bot Sep 16, 2024

va-vfs-bot Sep 16, 2024

va-vfs-bot Sep 16, 2024

va-vfs-bot Sep 16, 2024

va-vfs-bot Sep 16, 2024

va-vfs-bot left a comment

va-vfs-bot Sep 18, 2024

va-vfs-bot left a comment

va-vfs-bot Oct 4, 2024

va-vfs-bot left a comment

va-vfs-bot Oct 9, 2024

va-vfs-bot Oct 9, 2024

va-vfs-bot Oct 9, 2024

va-vfs-bot Oct 9, 2024

va-vfs-bot left a comment

va-vfs-bot Oct 16, 2024

va-vfs-bot Oct 16, 2024

va-vfs-bot left a comment

va-vfs-bot Nov 4, 2024

va-vfs-bot left a comment

va-vfs-bot Nov 12, 2024

		@@ -0,0 +1,15 @@
		/* eslint-disable @department-of-veterans-affairs/axe-check-required */

		@@ -0,0 +1,26 @@
		/* eslint-disable @department-of-veterans-affairs/axe-check-required */

		@@ -0,0 +1,14 @@
		/* eslint-disable @department-of-veterans-affairs/axe-check-required */

		@@ -0,0 +1,52 @@
		/* eslint-disable @department-of-veterans-affairs/axe-check-required */

		@@ -0,0 +1,180 @@
		/* eslint-disable @department-of-veterans-affairs/axe-check-required */

		@@ -0,0 +1,13 @@
		/* eslint-disable @department-of-veterans-affairs/axe-check-required */

		@@ -0,0 +1,23 @@
		/* eslint-disable @department-of-veterans-affairs/axe-check-required */

		@@ -0,0 +1,144 @@
		/* eslint-disable @department-of-veterans-affairs/axe-check-required */

		@@ -0,0 +1,33 @@
		/* eslint-disable @department-of-veterans-affairs/axe-check-required */

Integration form engine 2 #2273

Integration form engine 2 #2273

Conversation

ryguyk commented Sep 16, 2024 • edited Loading

Summary

Related issue(s)

Testing done

Screenshots

What areas of the site does it impact?

Acceptance criteria

Quality Assurance & Testing

Error Handling

Authentication

va-vfs-bot left a comment

Choose a reason for hiding this comment

ESLint is disabled

What you can do

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

va-vfs-bot left a comment

Choose a reason for hiding this comment

ESLint is disabled

What you can do

Choose a reason for hiding this comment

va-vfs-bot left a comment

Choose a reason for hiding this comment

ESLint is disabled

What you can do

Choose a reason for hiding this comment

va-vfs-bot left a comment

Choose a reason for hiding this comment

ESLint is disabled

What you can do

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

va-vfs-bot left a comment

Choose a reason for hiding this comment

ESLint is disabled

What you can do

Choose a reason for hiding this comment

Choose a reason for hiding this comment

va-vfs-bot left a comment

Choose a reason for hiding this comment

ESLint is disabled

What you can do

Choose a reason for hiding this comment

va-vfs-bot left a comment

Choose a reason for hiding this comment

ESLint is disabled

What you can do

Choose a reason for hiding this comment

ryguyk commented Sep 16, 2024 •

edited

Loading