-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-28709 in this section a11y iOS fix #2409
Conversation
@chriskim2311 Shamia and I took a look and we have a few comments:
We also noticed a difference in the styles regarding the active page and subnav, screenshots below: |
…ent-build into 28709-in-this-section-a11y
@laflannery Added the changes from your comments ready for you to re-review thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, approved! Shamia and I both want to test this on real mobile though once it's merged. Will you ping one or both of us once it's in staging?
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Summary
In this PR we add markup to the div containing the accordion dropdown to allow the cursor in iOS to stay once the drawer is open.
Related issue(s)
department-of-veterans-affairs/va.gov-team#28709
Testing done
Hard to test this in iOS. But checked that the new markup is showing locally.
Screenshots
What areas of the site does it impact?
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria
Quality Assurance & Testing
Error Handling