Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AskVA-1348: Configure app url for Ask VA to remove too #2414

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

hemeshvpatel
Copy link
Contributor

Summary

  • Remove 'too' from end of ask-va url
  • I am on the Ask VA team (this app is not in production)

Related issue(s)

Testing done

  • N/a

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

  • This only impacts the Ask VA form

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@hemeshvpatel hemeshvpatel self-assigned this Jan 14, 2025
@hemeshvpatel hemeshvpatel requested review from a team as code owners January 14, 2025 22:54
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/AskVA-1348--Update-Ask-VA-app-url January 14, 2025 23:05 Inactive
Copy link
Contributor

@joehall-tw joehall-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Copy link
Contributor

@joehall-tw joehall-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/AskVA-1348--Update-Ask-VA-app-url January 15, 2025 00:40 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/AskVA-1348--Update-Ask-VA-app-url January 22, 2025 00:07 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/AskVA-1348--Update-Ask-VA-app-url January 22, 2025 14:52 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/AskVA-1348--Update-Ask-VA-app-url January 22, 2025 15:36 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants