Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2-27-25 Updating web-components package #2462

Merged
merged 2 commits into from
Mar 3, 2025
Merged

Conversation

Andrew565
Copy link
Contributor

Are you removing or changing a registry.json entryName in this PR?

  • No, I'm not changing any entryNames (skip to Summary and delete the rest of this section)
  • Yes, I'm removing or changing an entryName

Summary

  • Updating web-components package
  • I work for the DST

Testing done

  • None

Screenshots

N/A

What areas of the site does it impact?

Updates DST web components across the site.

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@Andrew565 Andrew565 self-assigned this Feb 27, 2025
@Andrew565 Andrew565 requested review from a team as code owners February 27, 2025 14:21
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/update-web-comp-2-27-25 February 27, 2025 14:25 Inactive
@Andrew565 Andrew565 requested a review from a team as a code owner March 3, 2025 14:41
@va-vfs-bot va-vfs-bot requested a review from a team March 3, 2025 14:42
Copy link
Collaborator

@va-vfs-bot va-vfs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

@@ -1,3 +1,4 @@
/* eslint-disable @department-of-veterans-affairs/axe-check-required */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint disabled here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file just checks if the custom-elements are all defined, so no axe check is needed here.

Copy link
Contributor

@SnowboardTechie SnowboardTechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@Andrew565 Andrew565 merged commit b7b11f9 into main Mar 3, 2025
24 checks passed
@Andrew565 Andrew565 deleted the update-web-comp-2-27-25 branch March 3, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants