Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

102497 Update supply reordering app URL #2464

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

nichia
Copy link
Contributor

@nichia nichia commented Feb 28, 2025

Are you removing or changing a registry.json entryName in this PR?

  • [] No, I'm not changing any entryNames (skip to Summary and delete the rest of this section)
  • Yes, I'm removing or changing an entryName

If you are:

  1. Deleting an entryName: First search vets-website for references to this entryName that are not in the app folder (particularly in src/applications/static-pages/static-pages-entry.js and src/platform/forms/constants.js) and merge a PR that removes those references, if any.

    • Add the link to your merged vets-website PR here
  2. Changing an entryName: First search vets-website for references to this entryName that are not in the app folder (particularly in src/applications/static-pages/static-pages-entry.js and src/platform/forms/constants.js) and merge a PR that updates those references, if any.

If you do not do this, other applications will break!

Summary

Update entry for supply reordering app URL:

  • Old URL: /my-health/order-supplies
  • New URL: /my-health/order-medical-supplies

Related issue(s)

Testing done

  • Verified that the local changes allow the react application to be served at /my-health/order-medical-supplies

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@nichia nichia requested review from a team as code owners February 28, 2025 16:11
@nichia nichia requested review from radavis and kjsuarez February 28, 2025 16:12
Copy link
Contributor

@radavis radavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@rmessina1010 rmessina1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nichia nichia merged commit 6c88bb4 into main Mar 4, 2025
24 checks passed
@nichia nichia deleted the 102497-update-supply-reordering-url branch March 4, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants