Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE - VACMS 20740 - Use new medical records widget when not cerner #2467

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

eselkin
Copy link
Contributor

@eselkin eselkin commented Mar 3, 2025

DO NOT MERGE UNTIL 3/12/25

Are you removing or changing a registry.json entryName in this PR?

  • No, I'm not changing any entryNames (skip to Summary and delete the rest of this section)
  • Yes, I'm removing or changing an entryName

Summary

  • Alters whether to show the health-records CTA widget appId if the system uses non-Cerner EHR (VistA/MHV) and instead shows the modernized widget.
  • Adds graphql update to include system EHR on Medical Records pages. Adds check on that value to switch the app Id in the vista scenario.
  • Sitewide team

Related issue(s)

Testing done

  • Checked several facilities of different types.
  • Checked that in Cerner case medical-records widget uses the current id (Lovell VA). In Vista case (Los Angeles, San Francisco VA) the new widget id appears.

Screenshots

Cerner site - Lovell VA
VistA site - Los Angeles VA

What areas of the site does it impact?

VAMC System Medical Records Pages with React CTA Widgets

Acceptance criteria

Shows the new widget when the system is VistA - e.g. Los Angeles, SF
Shows the old widget when the system is Cerner - e.g. Lovell VA

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user - no, we need help testing this

Requested Feedback

Check various VA facilities

(in last build the GraphQL changes did not occur, pushed a change to see if they did)
If the changes happen the object in the console/debug for /san-francisco-health-care/locations/san-francisco-va-medical-center/ under ...fieldOffice.entity should have vamcEhrSystem. If it does not, change was still not pulled.

@eselkin eselkin changed the title VACMS - Use new medical records widget when not cerner VACMS 20740 - Use new medical records widget when not cerner Mar 4, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/use-new-medical-records-widget-when-not-cerner March 4, 2025 00:14 Inactive
@eselkin eselkin marked this pull request as ready for review March 4, 2025 01:17
@eselkin eselkin requested review from a team as code owners March 4, 2025 01:17
Copy link
Contributor

@randimays randimays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jilladams jilladams changed the title VACMS 20740 - Use new medical records widget when not cerner DO NOT MERGE - VACMS 20740 - Use new medical records widget when not cerner Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants