Skip to content

Commit

Permalink
squash 198
Browse files Browse the repository at this point in the history
  • Loading branch information
kalbfled committed Feb 24, 2025
1 parent bc7e963 commit cb9389e
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 6 deletions.
1 change: 1 addition & 0 deletions tests/test_files/html/block_quotes_action_link.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<blockquote>
<p><a href="https://www.youtube.com/watch?v=dQw4w9WgXcQ"><img alt="call to action img" src="https://dev-va-gov-assets.s3-us-gov-west-1.amazonaws.com/img/vanotify-action-link.png" class="action_link"><b>action link</b></a></p>
</blockquote>
<blockquote>
<p><a href="https://www.youtube.com/watch?v=dQw4w9WgXcQ"><img alt="call to action img" src="https://dev-va-gov-assets.s3-us-gov-west-1.amazonaws.com/img/vanotify-action-link.png" class="action_link"><b>action link</b></a></p>
</blockquote>
<blockquote>
Expand Down
2 changes: 1 addition & 1 deletion tests/test_files/html/images.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ <h1>Images should be removed</h1>
<h2>Inline images</h2>
<h2>Reference images</h2>
<p>The reference is immediately after the image.</p>
<p>The reference is not immediately after the iamge.</p>
<p>The reference is not immediately after the image.</p>
<p>This line separates the images from their references.</p>

2 changes: 1 addition & 1 deletion tests/test_files/html/lists.html
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
<li>item F</li>
</ul>
</li>
<li>item 3<ul>
<li>item 4<ul>
<li>item G</li>
<li>item H</li>
</ul>
Expand Down
4 changes: 2 additions & 2 deletions tests/test_files/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ The HTML files should not include any styling. The HTML output should get inser

## Supported markdown

VA Notify markdown support mostly aligns with [Github markdown](https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet). Some addtionally supported markdown includes:
VA Notify markdown support mostly aligns with [Github markdown](https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet). Some additionally supported markdown includes:

- The use of bullets ("•") to denote unordered lists
- The use of "^" to denote a block quote. The standard ">" also works. Block quotes can be nested, but this looks bad in plain text.
- Preface a link with ">>" to denote an "action link," with has specific styling for HTML output. Action links are treated like standard links for plain text output.

## Unsupported markdown

VA Notify markdown is not gauranteed to support:
VA Notify markdown is not guaranteed to support:

- Ordered sublists. Github markdown discusses ordered sublists [here](https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#lists), but a close inspection of the rendered output reveals that ordered sublists are not actually nested. (Unordered sublists are nested.)
- Sublists nested more than once
Expand Down
2 changes: 1 addition & 1 deletion tests/test_files/markdown/images.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ text before [image3]: https://www.example.com/test.tga
text before ![alt text][image4] text after
[image4]: https://www.example.com/test.png "title text"

The reference is not immediately after the iamge.
The reference is not immediately after the image.

![alt text][image5]
![alt text][image6]
Expand Down
2 changes: 1 addition & 1 deletion tests/test_files/plain_text/images.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Reference images

The reference is immediately after the image.

The reference is not immediately after the iamge.
The reference is not immediately after the image.

This line separates the images from their references.

0 comments on commit cb9389e

Please sign in to comment.