This repository is currently being migrated. It's locked while the migration is in progress.
Feature/12088 new file upload#13229
Open
AdryienH wants to merge 42 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Claims and Secure Messaging attachment experience behind a newFileUpload feature flag, introducing a shared <FileUpload /> UI and adding a new Claims “UploadFiles” screen/waygate.
Changes:
- Added a new reusable
components/FileUpload(with preview UI) plus supporting helpers/styles/theme tokens. - Wired Secure Messaging (Start/Reply/Edit Draft) and Claims (Submit Evidence + new UploadFiles screen) to use the new file upload flow when
newFileUploadis enabled. - Added new feature toggle (
newFileUpload) and a new waygate toggle (WG_UploadFiles).
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 19 comments.
Show a summary per file
| File | Description |
|---|---|
| VAMobile/src/utils/waygateConfig.ts | Adds WG_UploadFiles toggle to waygate config. |
| VAMobile/src/utils/secureMessaging.tsx | Adds multi-select attachment picking helpers used by the new flow. |
| VAMobile/src/utils/remoteConfig.ts | Adds newFileUpload feature flag default/type. |
| VAMobile/src/utils/remoteConfig.test.ts | Updates remote config override test object with new flag. |
| VAMobile/src/utils/fileUpload.ts | Adds helper functions for extracting URIs/base64 and summing sizes. |
| VAMobile/src/translations/en/common.json | Adds/updates file upload strings used by the new UI. |
| VAMobile/src/styles/themes/standardTheme.ts | Adds preview dimension tokens for file/image thumbnails. |
| VAMobile/src/styles/themes/colorSchemes.ts | Adds fileInfo text color token for light/dark themes. |
| VAMobile/src/styles/theme.ts | Extends theme typings for fileInfo and preview dimensions. |
| VAMobile/src/screens/HealthScreen/SecureMessaging/StartNewMessage/StartNewMessage.tsx | Switches attachments field to new FileUploadList when flagged. |
| VAMobile/src/screens/HealthScreen/SecureMessaging/ReplyMessage/ReplyMessage.tsx | Switches attachments field to new FileUploadList when flagged. |
| VAMobile/src/screens/HealthScreen/SecureMessaging/EditDraft/EditDraft.tsx | Switches attachments field to new FileUploadList when flagged. |
| VAMobile/src/screens/BenefitsScreen/.../UploadFiles/UploadFiles.tsx | Introduces a new Claims upload screen using <FileUpload />. |
| VAMobile/src/screens/BenefitsScreen/.../SubmitEvidence.tsx | Uses <FileUpload /> when the feature flag is enabled. |
| VAMobile/src/screens/BenefitsScreen/.../FileRequestSubtask.tsx | Adds UploadFiles route/screen to the claims upload stack. |
| VAMobile/src/components/FormWrapper/FormWrapper.tsx | Adds a new FieldType.FileUploadList to render <FileUpload />. |
| VAMobile/src/components/FileUpload/FileUpload.tsx | New shared file upload UI component. |
| VAMobile/src/components/FileUpload/FilePreview.tsx | New preview row component with delete confirmation. |
| VAMobile/src/api/types/ClaimsAndAppealsData.ts | Updates upload param typing for mixed Asset/DocumentPickerResponse arrays. |
| VAMobile/src/api/claimsAndAppeals/uploadFileToClaim.tsx | Updates function signatures to accept mixed file arrays. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
narin
suggested changes
Apr 16, 2026
Contributor
narin
left a comment
There was a problem hiding this comment.
Please review/address Copilot comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no requirement to implement the suggestions but please respond to Copilot review comments in some way. Unaddressed comments will prevent the PR from moving to the QA process.
Description of Change
<FileUpload/>componentTarget Release Date
Link to Issue
closes #12088
Code testing
Pre-QA Artifacts
Include all artifacts or select not applicable and explain below.
Default Screenshots
2x Screenshots
Landscape Screenshots
ScreenRecording_04-13-2026.15-36-45_1.MP4
How to capture these
Screenshots & Video
2x text size
Settings > Accessibility > Display & Text Size > Larger Text.Toggle ON, move slider.Settings > Accessibility > Display size and text.Adjust Font size and Display size sliders.VoiceOver / TalkBack (best on actual hardware)
Test Context for QA
How does a user get here?
Feature Flags
Feature flag:
newFileUploadRisk Assessment:
What should QA pay extra attention to?
Test Review
Test User(s)
Checklist for QA
QA Engineer: Check off the items below as you test
Run a build for this branch