Skip to content
This repository is currently being migrated. It's locked while the migration is in progress.

Ce 12885 add weeekly security audit#13302

Open
cachelina wants to merge 20 commits into
developfrom
ce-12885-add-weeekly-security-audit
Open

Ce 12885 add weeekly security audit#13302
cachelina wants to merge 20 commits into
developfrom
ce-12885-add-weeekly-security-audit

Conversation

@cachelina
Copy link
Copy Markdown
Contributor

@cachelina cachelina commented Apr 23, 2026

Description of Change

A new file weekly_security_audit.yml will assess vulnerabilities in the app by running a weekly yarn audit of the installed packages, and also a vtk scan of VAMobile. The va-mobile-app-alerts channel will send an alert if vulnerabilities found.

Note: Currently, the yarn audit is failing and there's a devops/FE effort to address these vulnerabilities. Until the effort is complete, the yarn audit will fail and send a weekly alert.

Target Release Date

n/a

Link to Issue

Closes #12885

Code testing

  • Unit tests have been created or updated to cover this change
  • End to end (Detox) tests have been added or updated as needed

Pre-QA Artifacts

Include all artifacts or select not applicable and explain below.

  • Screenshots or screen recording at factory default settings (before and after, if applicable) in portrait orientation
  • Screenshots in landscape orientation
  • Screenshots at 2x text size
  • Screen recording of interaction using VoiceOver (iOS) and/or TalkBack (Android)
  • Visual artifacts not applicable to this PR (explain why below)
n/a

Screenshots & Video

2x text size

  • iOS Dynamic Type: Settings > Accessibility > Display & Text Size > Larger Text. Toggle ON, move slider.
  • Android Font Scale: Settings > Accessibility > Display size and text. Adjust Font size and Display size sliders.

VoiceOver / TalkBack (best on actual hardware)

Test Context for QA

How does a user get here?

Feature Flags

Risk Assessment:

  • Low (UI polish, copy change, isolated component)
  • Medium (New feature, non-core path)
  • High (Changes to Core Features: Login, Claims, Rx, Secure Messaging, major updates to a backend service, etc.)

What should QA pay extra attention to?

Test Review

n/a

Test User(s)

n/a

Checklist for QA

QA Engineer: Check off the items below as you test
n/a

  • Shared Test Script executed (post results as a PR comment)
  • Feature-specific verification based on QA Test Context above
  • Tested on iOS
  • Tested on Android

Run a build for this branch

@cachelina cachelina requested a review from a team as a code owner April 23, 2026 14:11
Copilot AI review requested due to automatic review settings April 23, 2026 14:11
@flagship-mobile-app flagship-mobile-app Bot review requested due to automatic review settings April 23, 2026 14:13
@cachelina cachelina temporarily deployed to bypass-package-lock April 23, 2026 14:16 — with GitHub Actions Inactive
@flagship-mobile-app flagship-mobile-app Bot added the package-scan-complete npm package scanning complete label Apr 23, 2026
Comment thread .github/workflows/weekly-security-audit.yml Outdated
Comment thread .github/workflows/weekly-security-audit.yml Outdated
Comment thread .github/workflows/weekly-security-audit.yml Outdated
Comment thread .github/workflows/weekly-security-audit.yml Outdated
Comment thread .github/workflows/weekly-security-audit.yml Outdated
Comment thread .github/workflows/weekly-security-audit.yml Outdated
timeout_minutes: 10
command: cd VAMobile && yarn install --ignore-scripts --frozen-lockfile --non-interactive

- name: Run yarn audit
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im suggesting we comment this out for now until dependabot catches up. This will cause false positives and fail the job. Having false failures before real failures will create noise and we will miss the real failures.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented this out!

Copilot AI review requested due to automatic review settings April 28, 2026 17:10
@flagship-mobile-app flagship-mobile-app Bot review requested due to automatic review settings April 28, 2026 17:12
Copilot AI review requested due to automatic review settings April 28, 2026 17:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new GitHub Actions workflow intended to run recurring security checks against the develop branch and alert Slack when issues are detected.

Changes:

  • Introduces .github/workflows/weekly-security-audit.yml with a VTK repository scan job.
  • Adds a Slack notification job intended to post failures to a channel.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/weekly-security-audit.yml
Comment thread .github/workflows/weekly-security-audit.yml
Comment thread .github/workflows/weekly-security-audit.yml
Comment thread .github/workflows/weekly-security-audit.yml
@cachelina
Copy link
Copy Markdown
Contributor Author

I tested the vtk-scan runs and succeeds on push!

@cachelina cachelina temporarily deployed to bypass-package-lock April 28, 2026 17:19 — with GitHub Actions Inactive
@cachelina cachelina temporarily deployed to bypass-package-lock April 28, 2026 18:27 — with GitHub Actions Inactive
@cachelina cachelina temporarily deployed to bypass-package-lock April 28, 2026 18:33 — with GitHub Actions Inactive
@cachelina cachelina temporarily deployed to bypass-package-lock April 28, 2026 19:36 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package-scan-complete npm package scanning complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Devops - periodically run yarn audit

3 participants