Skip to content
This repository is currently being migrated. It's locked while the migration is in progress.

#141865 [Benefits Management Tools] [Team 2] Add cstLettersContentUpdates flag to AuthorizedServicesData.ts and change the default value in the remote config to true#13433

Open
JoshingYou1 wants to merge 4 commits into
developfrom
feature/141865-BenefitLettersContentUpdates-AddFeatureFlagToAuthorizedServicesData
Open

#141865 [Benefits Management Tools] [Team 2] Add cstLettersContentUpdates flag to AuthorizedServicesData.ts and change the default value in the remote config to true#13433
JoshingYou1 wants to merge 4 commits into
developfrom
feature/141865-BenefitLettersContentUpdates-AddFeatureFlagToAuthorizedServicesData

Conversation

@JoshingYou1
Copy link
Copy Markdown
Contributor

@JoshingYou1 JoshingYou1 commented May 11, 2026

Description of Change

  1. Adds cstLettersContentUpdates feature flag to AuthorizedServicesData.tsx
  2. Updates cstLettersContentUpdates in VAMobile/src/constants/featureFlags.ts to default to true
  3. Updates test code to reflect the changes.

Target Release Date

N/A

Link to Issue

Closes #141865

Code testing

  • Unit tests have been created or updated to cover this change
  • End to end (Detox) tests have been added or updated as needed

Pre-QA Artifacts

Include all artifacts or select not applicable and explain below.

  • Screenshots or screen recording at factory default settings (before and after, if applicable) in portrait orientation
  • Screenshots in landscape orientation
  • Screenshots at 2x text size
  • Screen recording of interaction using VoiceOver (iOS) and/or TalkBack (Android)
  • Visual artifacts not applicable to this PR (explain why below)

Flag defaults to "on"

Screenshot 2026-05-11 at 11 44 16 AM
How to capture these

Screenshots & Video

2x text size

  • iOS Dynamic Type: Settings > Accessibility > Display & Text Size > Larger Text. Toggle ON, move slider.
  • Android Font Scale: Settings > Accessibility > Display size and text. Adjust Font size and Display size sliders.

VoiceOver / TalkBack (best on actual hardware)

Test Context for QA

How does a user get here?

Feature Flags

Risk Assessment:

  • Low (UI polish, copy change, isolated component)
  • Medium (New feature, non-core path)
  • High (Changes to Core Features: Login, Claims, Rx, Secure Messaging, major updates to a backend service, etc.)

What should QA pay extra attention to?
Ensure the cstLettersContentUpdates flag defaults to true

Test Review
Updated some test user code as well as the test code for the feature flag and it's default value.

Test User(s)


Checklist for QA

QA Engineer: Check off the items below as you test

  • Shared Test Script executed (post results as a PR comment)
  • Feature-specific verification based on QA Test Context above
  • Tested on iOS
  • Tested on Android

Run a build for this branch

@flagship-mobile-app flagship-mobile-app Bot requested a review from a team May 11, 2026 02:03
@JoshingYou1 JoshingYou1 changed the title Added flag to necessary files #141865 [Benefits Management Tools] [Team 2] Add cstLettersContentUpdates flag to AuthorizedServicesData.tsx and change the default value in the remote config to true May 11, 2026
@JoshingYou1 JoshingYou1 requested a review from Copilot May 11, 2026 18:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for the cstLettersContentUpdates flag across authorized-services typings and demo-mode mocks, and flips the Firebase Remote Config default to enabled so the feature is “on” by default.

Changes:

  • Added cstLettersContentUpdates to the AuthorizedServicesPayload / UserAuthorizedServicesData TypeScript types.
  • Updated demo-mode getAuthorizedServices mocks to include the new cstLettersContentUpdates field.
  • Changed the Remote Config default for cstLettersContentUpdates to true.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
VAMobile/src/store/api/demo/mocks/kimberlyWashington/getAuthorizedServices.json Adds cstLettersContentUpdates to demo authorized-services response.
VAMobile/src/store/api/demo/mocks/kimberlyForOHMigration/getAuthorizedServicesNoErrorPhases.json Adds cstLettersContentUpdates to the OH-migration demo authorized-services response.
VAMobile/src/store/api/demo/mocks/kimberlyForOHMigration/getAuthorizedServices.json Adds cstLettersContentUpdates to the OH-migration demo authorized-services response.
VAMobile/src/store/api/demo/mocks/dennisMadison/getAuthorizedServices.json Adds cstLettersContentUpdates to demo authorized-services response.
VAMobile/src/store/api/demo/mocks/default/getAuthorizedServices.json Adds cstLettersContentUpdates to the default demo authorized-services response.
VAMobile/src/store/api/demo/mocks/claraJefferson/getAuthorizedServices.json Adds cstLettersContentUpdates to the claraJefferson demo authorized-services response.
VAMobile/src/constants/featureFlags.ts Sets Remote Config default cstLettersContentUpdates to true.
VAMobile/src/api/types/AuthorizedServicesData.ts Adds cstLettersContentUpdates to authorized-services payload/user types.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread VAMobile/src/api/types/AuthorizedServicesData.ts
@JoshingYou1 JoshingYou1 changed the title #141865 [Benefits Management Tools] [Team 2] Add cstLettersContentUpdates flag to AuthorizedServicesData.tsx and change the default value in the remote config to true #141865 [Benefits Management Tools] [Team 2] Add cstLettersContentUpdates flag to AuthorizedServicesData.ts and change the default value in the remote config to true May 11, 2026
lianafleming
lianafleming previously approved these changes May 12, 2026
Copy link
Copy Markdown
Contributor

@lianafleming lianafleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

randimays
randimays previously approved these changes May 12, 2026
@JoshingYou1 JoshingYou1 marked this pull request as ready for review May 12, 2026 19:03
@JoshingYou1 JoshingYou1 requested a review from a team as a code owner May 12, 2026 19:03
@dumathane
Copy link
Copy Markdown
Contributor

Need to resolve some conflicts.

@JoshingYou1 JoshingYou1 dismissed stale reviews from randimays and lianafleming via dd996d7 May 13, 2026 15:25
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ffairs/va-mobile-app into feature/141865-BenefitLettersContentUpdates-AddFeatureFlagToAuthorizedServicesData
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants