Skip to content
This repository is currently being migrated. It's locked while the migration is in progress.

adding oidc permissions#13449

Open
jbergman-oddball wants to merge 1 commit into
developfrom
chore.jb.user.id.update
Open

adding oidc permissions#13449
jbergman-oddball wants to merge 1 commit into
developfrom
chore.jb.user.id.update

Conversation

@jbergman-oddball
Copy link
Copy Markdown
Contributor

There is no requirement to implement the suggestions but please respond to Copilot review comments in some way. Unaddressed comments will prevent the PR from moving to the QA process.

Description of Change

This PR adds the id-token permission to the get-slack-id workflow so it can grab the slack api token secret

Target Release Date

Link to Issue

Code testing

  • Unit tests have been created or updated to cover this change
  • End to end (Detox) tests have been added or updated as needed

Pre-QA Artifacts

Include all artifacts or select not applicable and explain below.

  • Screenshots or screen recording at factory default settings (before and after, if applicable) in portrait orientation
  • Screenshots in landscape orientation
  • Screenshots at 2x text size
  • Screen recording of interaction using VoiceOver (iOS) and/or TalkBack (Android)
  • Visual artifacts not applicable to this PR (explain why below)
How to capture these

Screenshots & Video

2x text size

  • iOS Dynamic Type: Settings > Accessibility > Display & Text Size > Larger Text. Toggle ON, move slider.
  • Android Font Scale: Settings > Accessibility > Display size and text. Adjust Font size and Display size sliders.

VoiceOver / TalkBack (best on actual hardware)

Test Context for QA

How does a user get here?

Feature Flags

Risk Assessment:

  • Low (UI polish, copy change, isolated component)
  • Medium (New feature, non-core path)
  • High (Changes to Core Features: Login, Claims, Rx, Secure Messaging, major updates to a backend service, etc.)

What should QA pay extra attention to?

Test Review

Test User(s)


Checklist for QA

QA Engineer: Check off the items below as you test

  • Shared Test Script executed (post results as a PR comment)
  • Feature-specific verification based on QA Test Context above
  • Tested on iOS
  • Tested on Android

Run a build for this branch

Copilot AI review requested due to automatic review settings May 12, 2026 14:02
@jbergman-oddball jbergman-oddball requested a review from a team as a code owner May 12, 2026 14:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the reusable GitHub Actions workflow used to look up Slack user IDs so it can successfully use AWS OIDC (via aws-actions/configure-aws-credentials) to retrieve the Slack API token from SSM.

Changes:

  • Adds workflow-level permissions granting id-token: write and contents: read to enable OIDC-based AWS credential configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants