-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VAGOV-TEAM-96557: Default paragraphs #20382
Draft
ryguyk
wants to merge
23
commits into
main
Choose a base branch
from
VAGOV-TEAM-96557-default-paragraphs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,426
−217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- routing - controller method - theme definition - template - css
- Complete/incomplete status tags appear but are not accurate. - Steps 1-3 are hard-coded (subject to change).
- Calculates status for each step and passes to template. - Displays status on template according to passed-in values.
- Moves some logic from DigitalFormsService into the DigitalForm wrapper class to be more OOP.
…gital_form` node.
…ather than plain nodes.
…talForm wrapper class.
…urning value. - Updates test to check for this behavior.
- Adds functional test for Layout page.
Checking composer.lock changes... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a "Your personal information" chapter to a Digital Form when the form is first created using Form Builder UI. The chapter includes two sub-chapters ("Name and date of birth" and "Identification information").
Closes department-of-veterans-affairs/va.gov-team#96557
Testing done
Screenshots
Admin view after creating form in Form Builder:

QA steps
As ad admin:
/form-builder/form-info
.form-builder/{nid}/layout
.nid
value and manually navigate to/node/{nid}/edit
.Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing
Form Engine
Is this PR blocked by another PR?
DO NOT MERGE
Does this PR need review from a Product Owner
Needs PO review
CMS user-facing announcement
Is an announcement needed to let editors know of this change?