Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAGOV-TEAM-96557: Default paragraphs #20382

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

ryguyk
Copy link
Contributor

@ryguyk ryguyk commented Jan 31, 2025

Description

This adds a "Your personal information" chapter to a Digital Form when the form is first created using Form Builder UI. The chapter includes two sub-chapters ("Name and date of birth" and "Identification information").

Closes department-of-veterans-affairs/va.gov-team#96557

Testing done

  • Functional test updated. Confirms that default paragraph with sub-paragraphs exists after initial node creation.
  • Manually tested as well.

Screenshots

Admin view after creating form in Form Builder:
image

QA steps

As ad admin:

  1. Navigate to /form-builder/form-info.
    • Fill in form and click "Save and continue".
    • Validate that you are redirected to form-builder/{nid}/layout.
  2. On the Layout page.
    • Validate that the "Your personal information" step has "COMPLETE" status with green label.
    • Copy the nid value and manually navigate to /node/{nid}/edit.
  3. On the default/admin node-edit page:
    • Validate that the form has a "Your personal information" chapter.
    • Validate that the chapter contains two sub-chapters:
      • "Name and date of birth"
      • "Identification information"

Definition of Done

  • Documentation has been updated, if applicable.
  • [ x Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing
  • Form Engine

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

ryguyk added 21 commits January 30, 2025 13:52
- routing
- controller method
- theme definition
- template
- css
- Complete/incomplete status tags appear but are not accurate.
- Steps 1-3 are hard-coded (subject to change).
- Calculates status for each step and passes to template.
- Displays status on template according to passed-in values.
- Moves some logic from DigitalFormsService into the DigitalForm wrapper class to be more OOP.
…urning value.

- Updates test to check for this behavior.
- Adds functional test for Layout page.
@ryguyk ryguyk requested a review from a team as a code owner January 31, 2025 23:18
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 31, 2025 23:18 Destroyed
@ryguyk ryguyk requested a review from derekhouck January 31, 2025 23:18
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 1, 2025 08:50 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 2, 2025 08:48 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 3, 2025 08:53 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 8, 2025 08:44 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 9, 2025 08:48 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 10, 2025 08:46 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 11, 2025 08:50 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 12, 2025 08:52 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 13, 2025 08:47 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 14, 2025 08:39 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 15, 2025 08:38 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 16, 2025 08:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 17, 2025 08:36 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 18, 2025 08:35 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 19, 2025 08:36 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 20, 2025 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 21, 2025 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 22, 2025 08:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 23, 2025 08:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 24, 2025 08:40 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 25, 2025 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 26, 2025 08:38 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 27, 2025 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 28, 2025 08:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 1, 2025 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 2, 2025 08:35 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 3, 2025 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 4, 2025 08:35 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 5, 2025 08:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 6, 2025 08:35 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 7, 2025 08:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 8, 2025 08:34 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form Builder: Add default paragraphs upon initial node creation
2 participants