VACMS-16888: intranet only forms #20742

omahane · 2025-02-28T21:57:22Z

Description

Relates to #16888

Testing done

Manually

QA steps

Archive the IntranetOnly forms

Open the Terminal
Run drush va_gov_migrate:archive-intranet-only-forms
Go to Content
Confirm that 4 Forms were just archived
View one of the forms
Note the last revision is about archiving it

Regression test the archiving of facilities

Unarchive a facility no longer in the Facilities API (using any of the following)
- vc_7241OS, 17533 (node id)
- vc_6051OS, 17539 (node id)
- vc_3072OS, 46278 (node id)
- vc_3071OS, 46277 (node id)
- vc_0326MVC, 74409 (node id)
- vc_01081OS, 54299 (node id)
Run the drush va_gov_migrate:flag-missing-facilities command
Confirm that facility is now archived

Definition of Done

Documentation has been updated, if applicable.
Tests have been added if necessary.
Automated tests have passed.
Code Quality Tests have passed.
Acceptance Criteria in related issue are met.
Manual Code Review Approved.
If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

Is this PR blocked by another PR?

DO NOT MERGE

Does this PR need review from a Product Owner

Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

Yes, and it's written in issue ____ and queued for publication.
- Merge and ping the UX writer so they are ready to publish after deployment
Yes, but it hasn't yet been written
- Don't merge yet -- ping the UX writer to write and queue content
No announcement is needed for this code change.
- Merge & carry on unburdened by announcements

github-actions · 2025-02-28T21:57:44Z

Checking composer.lock changes...

jilladams · 2025-02-28T22:46:14Z

(There's a section in PR body about archived facilities - is that intentional / related to these changes? Guessing copy/ 🍝 )

omahane · 2025-03-03T15:30:22Z

(There's a section in PR body about archived facilities - is that intentional / related to these changes? Guessing copy/ 🍝 )

This is intentional because the change involved refactoring code that is used by the drush va_gov_migrate:flag-missing-facilities command. That's why I identified it as a regression test.

github-actions · 2025-03-03T17:11:03Z

Checking composer.lock changes...

dsasser

Looks good overall just some notes about exception handling and the question/confusion about previous archival methods used by archiveNode().

docroot/modules/custom/va_gov_migrate/src/Commands/Commands.php

github-actions · 2025-03-03T20:06:08Z

Checking composer.lock changes...

github-actions · 2025-03-03T20:06:11Z

GitHub Workflows (.github/workflows/*.yml)

Have you...

pinned all affected GitHub Actions at a specific commit by SHA?
reviewed the source code of the action at the commit you are pinning?
confirmed that no GitHub security measures are being bypassed?
checked for any injection of user content into protected contexts?
reviewed Security hardening for GitHub Actions?
reviewed GitHub Workflows?

github-actions · 2025-03-03T20:06:48Z

Checking composer.lock changes...

omahane

Added throws and responded about the archiving line.

docroot/modules/custom/va_gov_migrate/src/Commands/Commands.php

github-actions · 2025-03-03T20:13:59Z

Checking composer.lock changes...

github-actions · 2025-03-03T20:25:40Z

Checking composer.lock changes...

dsasser

Code looks good and QA + regression tests function as described.

dsasser · 2025-03-03T21:21:17Z

docroot/modules/custom/va_gov_migrate/src/Commands/Commands.php

-    $facility->setNewRevision(TRUE);
-    $facility->setUnpublished();
+    $message = 'Archived due to removal from Facility API.';
+    $this->archiveNode($facility, $message);


va-cms-bot · 2025-03-09T08:52:20Z

Tugboat has finished building the preview for this pull request!

Links:

Dashboard:

https://tugboat.vfs.va.gov/67c23145d00f033beb706179

va-cms-bot · 2025-03-09T10:49:39Z

Cypress Accessibility Violations

`/media/add/document`

ID: color-contrast
Impact: serious
Tags: cat.color, wcag2aa, wcag143, TTv5, TT13.c, EN-301-549, EN-9.1.4.3, ACT
Description: Ensure the contrast between foreground and background colors meets WCAG 2 AA minimum contrast ratio thresholds
Help: Elements must meet minimum color contrast ratio thresholds
Nodes:

HTML: <a href="/" class="toolbar-icon toolbar-icon-toolbar-menu toolbar-icon-toolbar-menu-sections trigger toolbar-item" data-drupal-subtrees="" id="toolbar-item-toolbar-menu-sections" data-toolbar-tray="toolbar-item-toolbar-menu-sections-tray" role="button" aria-pressed="false" style="background-color: rgb(2, 191, 231); border-bottom: 0px; color: rgb(33, 33, 33);">
Impact: serious
Target: #toolbar-item-toolbar-menu-sections
Summary: Fix any of the following:
Element has insufficient color contrast of 2.18 (foreground color: #ffffff, background color: #02bfe7, font size: 9.8pt (13px), font weight: bold). Expected contrast ratio of 4.5:1
HTML: <a href="/help" class="toolbar-icon toolbar-icon-help toolbar-item" style="background-color: rgb(2, 191, 231); border-bottom: 0px; color: rgb(33, 33, 33);">Knowledge Base</a>
Impact: serious
Target: .toolbar-icon-help
Summary: Fix any of the following:
Element has insufficient color contrast of 2.18 (foreground color: #ffffff, background color: #02bfe7, font size: 9.8pt (13px), font weight: bold). Expected contrast ratio of 4.5:1
HTML: <a href="/user" class="toolbar-icon toolbar-icon-user trigger toolbar-item" id="toolbar-item-user" data-toolbar-tray="toolbar-item-user-tray" role="button" aria-pressed="false" style="background-color: rgb(2, 191, 231); border-bottom: 0px; color: rgb(33, 33, 33);">test_Lupe.Morissette68</a>
Impact: serious
Target: #toolbar-item-user
Summary: Fix any of the following:
Element has insufficient color contrast of 2.18 (foreground color: #ffffff, background color: #02bfe7, font size: 9.8pt (13px), font weight: bold). Expected contrast ratio of 4.5:1

omahane added 3 commits February 26, 2025 10:17

VACMS-16888: Is getting the CSV and can parse it for rowid

c3f1a3a

VACMS-16888: Archives the IntranetOnly nodes.

5aa3e5e

VACMS-16888: Makes a drupal command and adds to tasks.

93ce056

omahane requested review from a team as code owners February 28, 2025 21:57

va-cms-bot temporarily deployed to Tugboat February 28, 2025 21:57 Destroyed

github-actions bot changed the title ~~Vacms 16888 intranet only forms~~ VACMS-16888: intranet only forms Feb 28, 2025

va-cms-bot temporarily deployed to Tugboat February 28, 2025 22:27 Destroyed

va-cms-bot temporarily deployed to Tugboat March 1, 2025 08:35 Destroyed

va-cms-bot temporarily deployed to Tugboat March 2, 2025 08:46 Destroyed

va-cms-bot temporarily deployed to Tugboat March 3, 2025 08:46 Destroyed

dsasser requested changes Mar 3, 2025

View reviewed changes

VACMS-16888: Adds exception handling.

a9143f7

omahane force-pushed the VACMS-16888-intranet-only-forms branch from 394868e to a9143f7 Compare March 3, 2025 20:05

omahane commented Mar 3, 2025

View reviewed changes

docroot/modules/custom/va_gov_migrate/src/Commands/Commands.php Show resolved Hide resolved

omahane force-pushed the VACMS-16888-intranet-only-forms branch from 5187c49 to b71d8e5 Compare March 3, 2025 20:13

VACMS-16888: Adds exception handling.

6ba0299

omahane force-pushed the VACMS-16888-intranet-only-forms branch from b71d8e5 to 6ba0299 Compare March 3, 2025 20:25

dsasser approved these changes Mar 3, 2025

View reviewed changes

va-cms-bot temporarily deployed to Tugboat March 4, 2025 08:38 Destroyed

va-cms-bot temporarily deployed to Tugboat March 5, 2025 08:36 Destroyed

va-cms-bot temporarily deployed to Tugboat March 6, 2025 08:37 Destroyed

va-cms-bot temporarily deployed to Tugboat March 7, 2025 08:36 Destroyed

va-cms-bot temporarily deployed to Tugboat March 8, 2025 08:36 Destroyed

va-cms-bot deployed to Tugboat March 9, 2025 08:36 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VACMS-16888: intranet only forms #20742

VACMS-16888: intranet only forms #20742

omahane commented Feb 28, 2025 •

edited by dsasser

Loading

github-actions bot commented Feb 28, 2025

jilladams commented Feb 28, 2025

omahane commented Mar 3, 2025 •

edited

Loading

github-actions bot commented Mar 3, 2025

dsasser left a comment

github-actions bot commented Mar 3, 2025

github-actions bot commented Mar 3, 2025

github-actions bot commented Mar 3, 2025

omahane left a comment

github-actions bot commented Mar 3, 2025

github-actions bot commented Mar 3, 2025

dsasser left a comment

dsasser Mar 3, 2025

va-cms-bot commented Mar 9, 2025

va-cms-bot commented Mar 9, 2025

VACMS-16888: intranet only forms #20742

Are you sure you want to change the base?

VACMS-16888: intranet only forms #20742

Conversation

omahane commented Feb 28, 2025 • edited by dsasser Loading

Description

Testing done

QA steps

Archive the IntranetOnly forms

Regression test the archiving of facilities

Definition of Done

Select Team for PR review

Is this PR blocked by another PR?

Does this PR need review from a Product Owner

CMS user-facing announcement

github-actions bot commented Feb 28, 2025

jilladams commented Feb 28, 2025

omahane commented Mar 3, 2025 • edited Loading

github-actions bot commented Mar 3, 2025

dsasser left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 3, 2025

github-actions bot commented Mar 3, 2025

GitHub Workflows (.github/workflows/*.yml)

github-actions bot commented Mar 3, 2025

omahane left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 3, 2025

github-actions bot commented Mar 3, 2025

dsasser left a comment

Choose a reason for hiding this comment

dsasser Mar 3, 2025

Choose a reason for hiding this comment

va-cms-bot commented Mar 9, 2025

va-cms-bot commented Mar 9, 2025

Cypress Accessibility Violations

/media/add/document

omahane commented Feb 28, 2025 •

edited by dsasser

Loading

omahane commented Mar 3, 2025 •

edited

Loading

`/media/add/document`