Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VATEAM-101163/101173/101166/101170: Custom Step components #20748

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

derekhouck
Copy link
Contributor

@derekhouck derekhouck commented Mar 3, 2025

Description

Creates the remaining components needed for the Custom Step Paragraph.

Testing done

Manually created a Digital Form with a Custom Step that featured multiple pages and components within it.

Screenshots

The components section of a Digital Form Page with different components added to it.
Screenshot 2025-03-03 at 1 27 58 PM

QA steps

As an administrator

  1. Go to Manage > Content > Add content > Digital Form
  2. In the "Steps" field, click "Add Step"
  3. Click "Add" underneath "Digital Form: Custom Step"
    • Verify the "Pages" field is present and populated with a Digital Form: Page Paragraph
    • Verify the "Components" field is present and empty
  4. Click "Add Component"
    • Verify a modal appears with buttons for the following components:
      - "Digital Form: Checkbox Component"
      - "Digital Form: Date Component"
      - "Digital Form: Radio Button Component"
      - "Digital Form: Text Area Component"
      - "Digital Form: Text Input Component"
  5. Click the button for a component.
    • Verify the "Label" field is required.
    • Verify the "Required?" checkbox is visible.
    • Verify the "Hint text" field is optional.
    • Repeat this step for all other components.
    • For the Date component, verify the "Date format" field appears with the following options:
      - "Month/Day/Year"
      - "Month/Year"
    • For the Radio Button and Checkbox components, verify the "Response Options" field appears and is populated with a "Digital Form: Response Option" with the following fields:
      - A required "Label" field
      - An optional "Description" field
  6. Fill out the required fields on the Digital Form and click "Save" at the bottom of the page.
    • Verify the Digital Form saves successfully.
    • Verify the "Digital Form: Custom Step" Paragraph is included in the "Steps" field of the view page.
    • Verify all the data you entered is reflected on the view page.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 3, 2025 19:23 Destroyed
Copy link

github-actions bot commented Mar 3, 2025

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 3, 2025 19:32 Destroyed
Copy link

github-actions bot commented Mar 3, 2025

GitHub Workflows (.github/workflows/*.yml)

Have you...

  • pinned all affected GitHub Actions at a specific commit by SHA?
  • reviewed the source code of the action at the commit you are pinning?
  • confirmed that no GitHub security measures are being bypassed?
  • checked for any injection of user content into protected contexts?
  • reviewed Security hardening for GitHub Actions?
  • reviewed GitHub Workflows?

Copy link

github-actions bot commented Mar 3, 2025

Checking composer.lock changes...

@derekhouck derekhouck requested a review from ryguyk March 3, 2025 19:41
@derekhouck derekhouck marked this pull request as ready for review March 3, 2025 19:41
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 4, 2025 08:46 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 5, 2025 08:36 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 6, 2025 08:37 Destroyed
Copy link
Contributor

@ryguyk ryguyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Looks like it'll be some fun content-build work 😅

@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 6, 2025 17:26 Destroyed
Copy link

github-actions bot commented Mar 6, 2025

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 7, 2025 08:36 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 7, 2025 16:02 Destroyed
Copy link

github-actions bot commented Mar 7, 2025

Checking composer.lock changes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants