VACMS-20193: Re-adds Germany and South Korea as states

[Becapa]

Description

Relates to #20193 and #23432.

Generated description

This pull request expands the functionality of the address module by allowing multiple countries to be added as US states, rather than just the Philippines. It also updates the service and test files to reflect this broader scope. The most important changes are grouped below by theme:

Feature Expansion:

• The event subscriber class was renamed from AddPhilippinesAsStateSubscriber to AddCountriesAsStatesSubscriber, and its logic was updated to add Germany (DEU) and South Korea (KR) as US subdivisions alongside the Philippines (PH). The subdivisions are now sorted by name for consistency. [1] [2]

Service Registration:

• The service definition in va_gov_address.services.yml was updated to reference the new class name, ensuring the correct event subscriber is registered.

Testing Updates:

• The unit test file was renamed and updated to test for the inclusion of Germany and South Korea as subdivisions in addition to the Philippines, and all references were changed to the new class name. [1] [2] [3]

Testing done

Screenshots

QA steps

As an admin

1. Edit the page - Pre-Discharge Site at Landstuhl Regional Medical Center
   • Validate that Both Germany and Delaware show up in the 'State' dropdown under 'Address'
   • Select 'Germany' from the 'State' dropdown
   • Validate that you can save the page without errors
2. Then edit the page - Pre-Discharge Site at U.S. Army Garrison Humphreys
   • Select 'South Korea' from the 'Sate dropdown under 'Address'
   • Validate that you can save the page without errors
3. The create a new 'Event' - /node/add/event
   • Fill in all required fields
   • For 'Location type' select 'At a non-VA location
   • Enter an address in Germany
   • Validate that you can save the event without errors
4. Edit the same event
   • Change the address to an address in South Korea
   • Validate that you can save the page without errors.
5. Create a News release - /node/add/press_release
   • Fill in all required fields
   • Enter a location in Germany
   • Validate that you can save without errors
6. Edit the News release
   • Change the location to South Korea
   • Validate that you can save without errors

Definition of Done

• Documentation has been updated, if applicable.
• Tests have been added if necessary.
• Automated tests have passed.
• Code Quality Tests have passed.
• Acceptance Criteria in related issue are met.
• Manual Code Review Approved.
• If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

• CMS Team
• Public websites
• Facilities
• User support
• Accelerated Publishing

Is this PR blocked by another PR?

• DO NOT MERGE

Does this PR need review from a Product Owner

• Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

• Yes, and it's written in issue ____ and queued for publication.
  • Merge and ping the UX writer so they are ready to publish after deployment
• Yes, but it hasn't yet been written
  • Don't merge yet -- ping the UX writer to write and queue content
• No announcement is needed for this code change.
  • Merge & carry on unburdened by announcements

[github-actions]

Checking composer.lock changes...

[Copilot]

Pull request overview

Expands the va_gov_address customization of Drupal Address subdivisions so that additional countries can be selected/saved via the US “State” dropdown (intended to include Germany and South Korea in addition to the Philippines).

Changes:

• Renames/updates the address subdivisions event subscriber to support adding multiple countries as US subdivisions.
• Updates the service definition to register the renamed subscriber.
• Updates unit tests to validate the additional subdivisions.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
docroot/modules/custom/va_gov_address/src/EventSubscriber/AddCountriesAsStatesSubscriber.php	Adds additional subdivisions (Germany, South Korea) to the US subdivisions list and sorts by name.
docroot/modules/custom/va_gov_address/va_gov_address.services.yml	Registers the renamed event subscriber service.
tests/phpunit/va_gov_address/unit/EventSubscriber/AddCountriesAsStatesSubscriberTest.php	Updates unit coverage to reflect the renamed subscriber and expanded subdivision set.

Comments suppressed due to low confidence (1)

docroot/modules/custom/va_gov_address/src/EventSubscriber/AddCountriesAsStatesSubscriber.php:51

• Germany is being added under subdivision key/code 'DEU' (ISO alpha-3), but the expected value for saving in the Address widget is typically ISO alpha-2 ('DE') (and the updated unit test/acceptance criteria expect 'DE|Germany'). Using 'DEU' here will both fail the unit test and likely produce the wrong stored subdivision value. Switch the subdivision key/code/id to 'DE'.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Checking composer.lock changes...

[SnowboardTechie]

👍🏻

[github-actions]

Checking composer.lock changes...

[va-cms-bot]

Tugboat has finished building the preview for this pull request!

Links:

• https://pr23705-5om6jiydtcxeq6zygn95dwdrrfy2ld7g.ci.cms.va.gov
• https://cms-5om6jiydtcxeq6zygn95dwdrrfy2ld7g.ci.cms.va.gov
• https://web-5om6jiydtcxeq6zygn95dwdrrfy2ld7g.ci.cms.va.gov
• https://next-5om6jiydtcxeq6zygn95dwdrrfy2ld7g.ci.cms.va.gov

Dashboard:

• https://tugboat.vfs.va.gov/69b2dafc343c501b6fd1dfad

[va-cms-bot]

Cypress Accessibility Violations

/test-data-sed

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, TTv5, TT6.a, EN-301-549, EN-9.4.1.2, ACT
Description: Ensure buttons have discernible text
Help: Buttons must have discernible text
Nodes:

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
  Impact: critical
  Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element does not have an implicit (wrapped) <label>
  Element does not have an explicit <label>
  Element's default semantics were not overridden with role="none" or role="presentation"

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
  Impact: critical
  Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element does not have an implicit (wrapped) <label>
  Element does not have an explicit <label>
  Element's default semantics were not overridden with role="none" or role="presentation"

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
  Impact: critical
  Target: button[data-proofing-help-title="About 'Main content' field"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element does not have an implicit (wrapped) <label>
  Element does not have an explicit <label>
  Element's default semantics were not overridden with role="none" or role="presentation"