Skip to content
This repository is currently being migrated. It's locked while the migration is in progress.

VACMS-24047: Updates nvm to 22#24211

Open
omahane wants to merge 1 commit into
mainfrom
VACMS-24047-update-nvm
Open

VACMS-24047: Updates nvm to 22#24211
omahane wants to merge 1 commit into
mainfrom
VACMS-24047-update-nvm

Conversation

@omahane
Copy link
Copy Markdown
Contributor

@omahane omahane commented May 4, 2026

Description

Relates to #24047

Generated description

(Select this text, hit the Copilot button, and select "Generate".)

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Do this
    • Validate that
  2. Then
    • Validate that
  3. Then validate Acceptance Criteria from issue
    • a
    • b
    • c

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

Copilot AI review requested due to automatic review settings May 4, 2026 16:48
@omahane omahane requested a review from a team as a code owner May 4, 2026 16:48
@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 4, 2026 16:48 Destroyed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Checking composer.lock changes...

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the bootstrap script that installs Node via nvm, with the apparent goal of moving local/container setup toward the repository’s current Node 22 baseline. In this codebase, that script is used by DDEV and Tugboat startup flows.

Changes:

  • Changes scripts/install-nvm.sh to install Node 22.13.0 instead of 16.19.1.
  • Aligns that script with the current root .nvmrc value.
  • Leaves the rest of the repository’s Node version pins unchanged.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/install-nvm.sh
[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion" # This loads nvm bash_completion

nvm install 16.19.1
nvm install 22.13.0
Comment thread scripts/install-nvm.sh
[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion" # This loads nvm bash_completion

nvm install 16.19.1
nvm install 22.13.0
@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 5, 2026 08:39 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 6, 2026 08:42 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 7, 2026 08:35 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 8, 2026 08:28 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 9, 2026 08:29 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 10, 2026 08:28 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 11, 2026 08:30 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 12, 2026 08:30 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 13, 2026 08:32 Destroyed
@va-cms-bot
Copy link
Copy Markdown
Collaborator

Cypress Accessibility Violations

/test-data-fugit

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, TTv5, TT6.a, EN-301-549, EN-9.4.1.2, ACT
Description: Ensure buttons have discernible text
Help: Buttons must have discernible text
Nodes:

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
    Impact: critical
    Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: button[data-proofing-help-title="About 'Main content' field"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants