Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fed engineer PR reviewer checklist #104285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fed engineer PR reviewer checklist #104285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions .github/ISSUE_TEMPLATE/approved-reviewers-request.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
---
name: Fed. engineer PR approver checklist
about: Checklist to ensure you are prepared to become a PR approver for your team's code
title: ''
labels: ['']
assignees: ''
---
# PR Approver Preparation Checklist

Certain federal engineers can get approval to review their team's code and bypass a Platform PR review. Use this checklist to ensure you are prepared to become a PR approver for your team's code.

**Engineer Name:**

**Team Name & [GitHub Team](https://github.com/orgs/department-of-veterans-affairs/teams):**
<!-- Name of your team and code-owning GitHub team(s) -->

## Training

- [ ] Thoroughly review the [Code review guide for vets-api](https://vfs.atlassian.net/wiki/spaces/BCP/pages/3155394563/Code+review+guide+for+vets-api).
- [ ] Review and save this [PR tips page](https://vfs.atlassian.net/wiki/spaces/BCP/pages/3918135327/PR+tips+for+federal+engineers) for details once you start reviewing and merging PRs.
- [ ] I understand I am responsible for the code my team deploys.

## Tools and Access

- [ ] I have access to the necessary repositories.
- [ ] I have the required permissions to approve and merge PRs within the repository my team works in.
- [ ] I can view a list of open PRs needing my approval. Here's an [example query](https://github.com/pulls?q=is%3Apr+is%3Aopen+draft%3Afalse+NOT+WIP+in%3Atitle+team-review-requested%3Adepartment-of-veterans-affairs%2Fbackend-review-group). Replace `backend-review-group` with your code-owning GitHub Team and modify the query as needed ([GH search docs](https://docs.github.com/en/search-github/searching-on-github/searching-issues-and-pull-requests)).

## Communication and Collaboration

- [ ] Meet with the Community of Practice (CoP). Reach out in the CoP Slack channel for a CoP meeting invite.
- [ ] I have discussed my role as a PR approver with my team.
- [ ] I understand I can reach out in the CoP Slack channel with PR questions.

## Approval
- [ ] Approved by Bill Chapman
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we shouldn't same something like Approved by OCTO Leadership or something like that. I could see Bill being one of the main approvers but most likely not the only one?

Or, maybe leave as is for now and we can see how it flows and adjust later if we believe it needs it.