Merge branch 'master' into dbex/104113-schema-updates-evidence-treatment

.github/CODEOWNERS

@@ -64,7 +64,6 @@ app/controllers/v0/backend_statuses_controller.rb @department-of-veterans-affair
 app/controllers/v0/benefits_claims_controller.rb @department-of-veterans-affairs/benefits-management-tools-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/benefits-admin
 app/controllers/v0/benefits_documents_controller.rb @department-of-veterans-affairs/benefits-management-tools-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/benefits-admin
 app/controllers/v0/benefits_reference_data_controller.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
-app/controllers/v0/burial_claims_controller.rb @department-of-veterans-affairs/mbs-core-team @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/controllers/v0/caregivers_assistance_claims_controller.rb @department-of-veterans-affairs/vfs-10-10 @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/controllers/v0/claim_documents_controller.rb @department-of-veterans-affairs/Disability-Experience @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/controllers/v0/claim_letters_controller.rb @department-of-veterans-affairs/benefits-management-tools-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/benefits-admin
@@ -144,15 +143,13 @@ app/controllers/v0/user @department-of-veterans-affairs/octo-identity
 app/controllers/v0/users_controller.rb @department-of-veterans-affairs/octo-identity
 app/controllers/v0/veteran_readiness_employment_claims_controller.rb @department-of-veterans-affairs/benefits-non-disability @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/controllers/v0/virtual_agent @department-of-veterans-affairs/vfs-virtual-agent-chatbot @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
-app/controllers/v0/virtual_agent_claim_letters_controller.rb @department-of-veterans-affairs/vfs-virtual-agent-chatbot @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/controllers/v0/virtual_agent_jwt_token_controller.rb @department-of-veterans-affairs/vfs-virtual-agent-chatbot @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/controllers/v0/virtual_agent/jwt_token.rb @department-of-veterans-affairs/vfs-virtual-agent-chatbot @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/controllers/v0/virtual_agent/report_to_cxdw.rb @department-of-veterans-affairs/vfs-virtual-agent-chatbot @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/controllers/v0/virtual_agent_speech_token_controller.rb @department-of-veterans-affairs/vfs-virtual-agent-chatbot @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/controllers/v0/virtual_agent_token_controller.rb @department-of-veterans-affairs/vfs-virtual-agent-chatbot @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/controllers/v0/virtual_agent_token_msft_controller.rb @department-of-veterans-affairs/vfs-virtual-agent-chatbot @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/controllers/v0/virtual_agent_token_nlu_controller.rb @department-of-veterans-affairs/vfs-virtual-agent-chatbot @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
-app/controllers/v0/virtual_agent/virtual_agent_appeal_controller.rb @department-of-veterans-affairs/vfs-virtual-agent-chatbot @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/controllers/v0/virtual_agent/virtual_agent_claim_status_controller.rb @department-of-veterans-affairs/vfs-virtual-agent-chatbot @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/controllers/v0/veteran_onboardings_controller.rb @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/va-iir
 app/controllers/v1/apidocs_controller.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
@@ -1134,7 +1131,6 @@ spec/controllers/v0/ask_va @department-of-veterans-affairs/ask-va-team @departme
 spec/controllers/v0/average_days_for_claim_completion_controller_spec.rb @department-of-veterans-affairs/benefits-microservices @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/controllers/v0/benefits_claims_controller_spec.rb @department-of-veterans-affairs/benefits-management-tools-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/benefits-admin
 spec/controllers/v0/benefits_reference_data_controller_spec.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
-spec/controllers/v0/burial_claims_controller_spec.rb @department-of-veterans-affairs/mbs-core-team @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/controllers/v0/caregivers_assistance_claims_controller_spec.rb @department-of-veterans-affairs/vfs-10-10
 spec/controllers/v0/claim_letters_controller_spec.rb @department-of-veterans-affairs/benefits-management-tools-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/benefits-admin
 spec/controllers/v0/contact_us @department-of-veterans-affairs/ask-va-team @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
@@ -1177,7 +1173,6 @@ spec/controllers/v0/veteran_onboardings_controller_spec.rb @department-of-vetera
 spec/controllers/v0/virtual_agent @department-of-veterans-affairs/vfs-virtual-agent-chatbot @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/controllers/v0/virtual_agent_token_msft_controller_spec.rb @department-of-veterans-affairs/vfs-virtual-agent-chatbot @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/controllers/v0/virtual_agent_token_nlu_controller_spec.rb @department-of-veterans-affairs/vfs-virtual-agent-chatbot @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
-spec/controllers/v0/virtual_agent_claim_letters_controller_spec.rb @department-of-veterans-affairs/vfs-virtual-agent-chatbot @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/controllers/v1/decision_review_notification_callbacks_controller_spec.rb @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/benefits-admin
 spec/controllers/v1/gids @department-of-veterans-affairs/govcio-vfep-codereviewers @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/controllers/v1/post911_gi_bill_statuses_controller_spec.rb @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/govcio-vfep-codereviewers

.github/workflows/deploy-template.yml

@@ -59,12 +59,12 @@ jobs:
           ssm_parameter: /devops/VA_VSP_BOT_GITHUB_TOKEN
           env_variable_name: VA_VSP_BOT_GITHUB_TOKEN
 
-      - name: Install yq if needed
+      - name: Install yq
         run: |
-          sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-keys CC86BB64
-          sudo add-apt-repository ppa:rmescandon/yq
-          sudo apt update
-          sudo apt install yq -y
+          wget https://github.com/mikefarah/yq/releases/latest/download/yq_linux_amd64 -O yq
+          chmod +x yq
+          sudo mv yq /usr/local/bin/
+          yq --version
 
       - name: Check out Manifest Repo
         uses: actions/checkout@v4

app/controllers/concerns/vet360/transactionable.rb

@@ -23,7 +23,7 @@ def check_transaction_status!
     private
 
     def service
-      if Flipper.enabled?(:va_v3_contact_information_service, @current_user)
+      if Flipper.enabled?(:remove_pciu, @current_user)
         VAProfile::V2::ContactInformation::Service.new @current_user
       else
         VAProfile::ContactInformation::Service.new @current_user

app/controllers/concerns/vet360/writeable.rb

@@ -27,7 +27,7 @@ def write_to_vet360_and_render_transaction!(type, params, http_verb: 'post')
     end
 
     def invalidate_cache
-      if Flipper.enabled?(:va_v3_contact_information_service, @current_user)
+      if Flipper.enabled?(:remove_pciu, @current_user)
         VAProfileRedis::V2::Cache.invalidate(@current_user)
       else
         VAProfileRedis::Cache.invalidate(@current_user)
@@ -38,7 +38,7 @@ def invalidate_cache
 
     def build_record(type, params)
       # This needs to be refactored after V2 upgrade is complete
-      if type == 'address' && Flipper.enabled?(:va_v3_contact_information_service, @current_user)
+      if type == 'address' && Flipper.enabled?(:remove_pciu, @current_user)
         model = 'VAProfile::Models::V3::Address'
         # Ensures the address_pou is valid
         params[:address_pou] = 'RESIDENCE' if params[:address_pou] == 'RESIDENCE/CHOICE'
@@ -61,7 +61,7 @@ def validate!(record)
     end
 
     def service
-      if Flipper.enabled?(:va_v3_contact_information_service, @current_user)
+      if Flipper.enabled?(:remove_pciu, @current_user)
         VAProfile::V2::ContactInformation::Service.new @current_user
       else
         VAProfile::ContactInformation::Service.new @current_user

app/controllers/v0/health_care_applications_controller.rb

@@ -12,7 +12,7 @@ class HealthCareApplicationsController < ApplicationController
     service_tag 'healthcare-application'
     FORM_ID = '1010ez'
 
-    skip_before_action(:authenticate, only: %i[create show enrollment_status healthcheck facilities])
+    skip_before_action(:authenticate, only: %i[create show enrollment_status healthcheck facilities download_pdf])
 
     before_action :record_submission_attempt, only: :create
     before_action :load_user, only: %i[create enrollment_status]
@@ -83,8 +83,28 @@ def facilities
       render(json: active_facilities(lighthouse_facilities))
     end
 
+    # If we were unable to submit the user's claim digitally, we allow them to the download
+    # the 10-10EZ PDF, pre-filled with their data, for them to mail in.
+    def download_pdf
+      source_file_path = PdfFill::Filler.fill_form(health_care_application, SecureRandom.uuid)
+
+      client_file_name = file_name_for_pdf(health_care_application.parsed_form)
+      file_contents    = File.read(source_file_path)
+
+      send_data file_contents, filename: client_file_name, type: 'application/pdf', disposition: 'attachment'
+    ensure
+      File.delete(source_file_path) if source_file_path && File.exist?(source_file_path)
+    end
+
     private
 
+    def file_name_for_pdf(parsed_form)
+      veteran_name = parsed_form.try(:[], 'veteranFullName')
+      first_name = veteran_name.try(:[], 'first') || 'First'
+      last_name = veteran_name.try(:[], 'last') || 'Last'
+      "10-10EZ_#{first_name}_#{last_name}.pdf"
+    end
+
     def active_facilities(lighthouse_facilities)
       active_ids = active_ves_facility_ids
       lighthouse_facilities.select { |facility| active_ids.include?(facility.unique_id) }

app/controllers/v0/profile/address_validation_controller.rb

@@ -13,7 +13,7 @@ class AddressValidationController < ApplicationController
       skip_before_action :authenticate, only: [:create]
 
       def create
-        address = if Flipper.enabled?(:va_v3_contact_information_service)
+        address = if Flipper.enabled?(:remove_pciu)
                     VAProfile::Models::V3::ValidationAddress.new(address_params)
                   else
                     VAProfile::Models::ValidationAddress.new(address_params)
@@ -49,7 +49,7 @@ def address_params
       end
 
       def service
-        @service ||= if Flipper.enabled?(:va_v3_contact_information_service)
+        @service ||= if Flipper.enabled?(:remove_pciu)
                        VAProfile::V3::AddressValidation::Service.new
                      else
                        VAProfile::AddressValidation::Service.new

app/controllers/v0/profile/persons_controller.rb

@@ -12,7 +12,7 @@ class PersonsController < ApplicationController
       after_action :invalidate_mpi_cache
 
       def initialize_vet360_id
-        response = if Flipper.enabled?(:va_v3_contact_information_service, @current_user)
+        response = if Flipper.enabled?(:remove_pciu, @current_user)
                      VAProfile::V2::Person::Service.new(@current_user).init_vet360_id
                    else
                      VAProfile::Person::Service.new(@current_user).init_vet360_id

app/controllers/v0/profile/transactions_controller.rb

@@ -29,7 +29,7 @@ def transaction_params
       end
 
       def service
-        if Flipper.enabled?(:va_v3_contact_information_service, @current_user)
+        if Flipper.enabled?(:remove_pciu, @current_user)
           VAProfile::V2::ContactInformation::Service.new @current_user
         else
           VAProfile::ContactInformation::Service.new @current_user

app/controllers/v0/veteran_readiness_employment_claims_controller.rb

@@ -46,7 +46,7 @@ def encrypted_user
         uuid: current_user.uuid,
         icn: current_user.icn,
         first_name: current_user.first_name,
-        va_profile_email: current_user.va_profile_email || current_user.va_profile_v2_email
+        va_profile_email: current_user.va_profile_email
       )
       KmsEncrypted::Box.new.encrypt(user_struct.to_h.to_json)
     end