95912 Check most recent status prior to sending ZSF email - IVC CHAMPVA forms #20044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-check-most-recent-status-prior-to-sending-zsf-email
va-vfs-bot
temporarily deployed
to
95912-check-most-recent-status-prior-to-sending-zsf-email/main/main
michaelclement
commented
Dec 27, 2024
Comment on lines
57
to
82
| ## | ||
| # Checks if a provided IvcChampvaForm record has a corresponding PEGA report | ||
| # | ||
| # @param record [IvcChampvaForm] the form record to check against the PEGA reporting API | ||
| # @return [Hash|boolean] Either a single PEGA report or `false` (if no report was found) | ||
| def record_has_matching_report(record) | ||
| # A report looks like: | ||
| # { | ||
| # "Creation Date"=>"2024-12-17T07:42:28.307000", | ||
| # "PEGA Case ID"=>"D-XXXXX", | ||
| # "Status"=>"Processed" | ||
| # } | ||
|
|
||
| # Querying by date requires a window of at least 1 day: | ||
| date_start = record.created_at.strftime('%m/%d/%Y') | ||
| date_end = (record.created_at + 1.day).strftime('%m/%d/%Y') | ||
| # There should only be one match per case ID, so query reports and grab 0th item: | ||
| # TODO: | ||
| # In practice this won't actually work, because any report with a `nil` | ||
| # `pega_status` on our side won't actually have a `case_id` to filter by... | ||
| # what we REALLY need is to add the `form_uuid` property into the PEGA reports | ||
| report = get_report(date_start, date_end).select { |rep| rep['PEGA Case ID'] == record.case_id }[0] | ||
| # If a report exists, return the IVC record and the corresponding report | ||
| # otherwise, return false | ||
| record && report ? report : false | ||
| end |
There was a problem hiding this comment.
This is the actual contribution of this PR so far.
va-vfs-bot
temporarily deployed
to
95912-check-most-recent-status-prior-to-sending-zsf-email/main/main
va-vfs-bot
temporarily deployed
to
95912-check-most-recent-status-prior-to-sending-zsf-email/main/main
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
Keep |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
Keep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?